CI: workaround for incompatible compiler release binary #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
With go1.11 `go test` in GOPATH mode somehow seems to depend on GCC. See golang/go#28065 This change only enables cgo for CI profiles that need it. Those are the ones that seem to fail on TravisCI now, presumably due to some compiler version missmatch. That is a workaround and does not happen in GO11MODULE mode. Signed-off-by: Alexander Bezzubov <bzz@apache.org>
See https://docs.travis-ci.com/user/reference/trusty/#container-based-infrastructure and https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration#timeline---its-happening-fast Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
This was referenced Apr 11, 2019
Merged
creachadair
reviewed
Apr 11, 2019
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
|
@creachadair all feedback addressed, ready for another round! |
creachadair
approved these changes
Apr 11, 2019
There was a problem hiding this comment.
I suppose there might have been an earlier export of that variable in the same dynamic extent. Once it's exported, it stays that way even if reassigned. But I think it's good documentation to be explicit, and protects us from non-strict dependency breakages. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of full distro update to get newer compiler #221 - fix last known good go release versions on CI.
This will un-block the next, before-modules release.
.xgo version will be restored as soon as both new 1.11 and 1.12 are released #221 (comment)