Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Devops pipeline to Github workflow Migration #2

Merged
merged 87 commits into from
Nov 29, 2023

Conversation

singhgss
Copy link
Contributor

@singhgss singhgss commented Nov 8, 2023

Overview/Summary

This PR brings Github development pipeline for Azure CAC Solutions. [CSPM-9]
Replace this with a brief description of what this Pull Request fixes, changes, etc.

  1. Logs In to ENT tenant using federated identity and uses azure sign tool to use cert from ENT keyVault to sign all PowerShell scripts and modules.
  2. Validates Code Signatures
  3. Tests module Imports
  4. Zip all signed modules.
  5. Logs In to Test tenant using federated identity
  6. Stages Signed Modules in a Storage Account.
  7. Pre Clean any previous CAC Solution Installed in the Tenant.
  8. Deploys CAC to Test Tenant.
  9. Wait for runbooks (main and backend) to finish successful run.
  10. It also fixes issue CSPM-3, CSPM-4

Breaking Changes

N/A

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@singhgss singhgss changed the title [WIP] - Azure Devops pipeline to Github workflow Migration Azure Devops pipeline to Github workflow Migration Nov 29, 2023
Copy link
Contributor

@alalvi00 alalvi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as the checks have passed. Great work on the cert signing!

Copy link
Contributor

@dutt0 dutt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great work on the development pipeline.

@singhgss singhgss merged commit 182c8d6 into main Nov 29, 2023
3 checks passed
@singhgss singhgss deleted the gsingh/migrate-devops-pipeline-github branch November 29, 2023 20:05
dutt0 pushed a commit that referenced this pull request Feb 1, 2024
* Change SubName to ID

* Created a detailed Design Doc

* add H1 Title

* Fixed Docs titles

* Add DDoS disclamer

* Increased Module version

* API attempt

* clean up Main

* Update Check-LoggingAndMonitoring.psd1 (#2)

Increase Version

* Improve setup.MD

* FIxing MD format
dutt0 pushed a commit that referenced this pull request Feb 1, 2024
* Change SubName to ID

* Created a detailed Design Doc

* add H1 Title

* Fixed Docs titles

* Add DDoS disclamer

* Increased Module version

* API attempt

* clean up Main

* Update Check-LoggingAndMonitoring.psd1 (#2)

Increase Version

* Improve setup.MD

* FIxing MD format

* Flter Sub with Enabled Status only

* adjust the error Action param

Co-authored-by: Jose Fehse <jose@fehse.ca>
dutt0 pushed a commit that referenced this pull request Feb 1, 2024
switch from AAD to MS Entra ID naming
dutt0 pushed a commit that referenced this pull request Feb 1, 2024
* initial commit for workflow

* Added cleanup and deployment actions

* fix indendtation

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* empty change

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* fix tag json

* update tags

* trigger only when merge targets PR

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants