Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Plugin not picking up certain flashcards #915

Closed
bgreenawald opened this issue Mar 22, 2024 · 34 comments
Closed

[BUG] Plugin not picking up certain flashcards #915

bgreenawald opened this issue Mar 22, 2024 · 34 comments
Labels
bug Something isn't working

Comments

@bgreenawald
Copy link

Describe the bug
The plugin suddenly only picks up ~half of the flashcards in my Vault. As of a few days ago, I had nearly 500 flashcards, but when I loaded the flashcard review today, it only showed that I had around 250 flashcards. I can confirm that all the other flashcards are still in the Vault and found an example of a file with flashcards past their review date that weren't being picked up at all. I currently don't see any pattern between what it picks up and what it doesn't.

Versions (please complete the following information):

  • OS: Windows 11, Android
  • Obsidian version: 1.5.11
  • Plugin version: 1.12.1
  • If on desktop, Installer version: 1.4.13
@bgreenawald bgreenawald added the bug Something isn't working label Mar 22, 2024
@ronzulu
Copy link
Collaborator

ronzulu commented Mar 22, 2024

Hi @bgreenawald

Thanks for letting us know.

Could you please post (as attachment, not copy/paste) a markdown file that contains flashcard(s) that don't appear in the review modal.

Also, please attach the plugin's settings file, located e.g.
D:\Obsidian\.obsidian\plugins\obsidian-spaced-repetition\data.json

Cheers
Ronny

@bgreenawald
Copy link
Author

Hi Ronny,

Thanks for the quick response. Attached is an example file that isn't showing up. Here is a picture of the current review screen:
image

Best,
Ben

Avicenna.md
data.json

@Garg0yle
Copy link

I'm having the same issue all of a sudden. From about 50-60 flashcards in my vault to 2. Here are attachments. Thanks for your work on this plugin btw

The Taliban at war_ 2001-2018.md

data.json

@Yury-Dictum
Copy link

Yury-Dictum commented Mar 25, 2024 •
edited
Loading

Hi! Same problem here. Two days ago there used to be around 130 cards in the queue, now there are none.

3. 🚮 giving smb a hard time.md

data.json

Sorry, forgot to include the environment info.
I'm on Win10
Obsidian 1.5.11
plugin version 1.12.1

I'm not sure what is meant by 'installer version'. If it's about Obsidian, the installer version is the same as the release version.

@ronzulu
Copy link
Collaborator

ronzulu commented Mar 25, 2024

Thanks, I can reproduce the problem now, hopefully fixed tomorrow

@Scicily
Copy link

Scicily commented Mar 25, 2024 •
edited
Loading

I'm having the same issue all of a sudden, too.

OS: macOS Sonoma 14.4

Obsidian version: 1.5.11

Plugin version: 1.12.1

@ronzulu
Copy link
Collaborator

ronzulu commented Mar 26, 2024

Hi all

Beta release is now available.

There is a file called main.js in this zip file
main_915A.zip

You will need to copy that to the obsidian plug-in folder, e.g.
D:\Obsidian\Obsidian\.obsidian\plugins\obsidian-spaced-repetition

Then reload the plug-in, or restart obsidian.

Any feedback appreciated.

Ronny

@Effeh
Copy link

Effeh commented Mar 26, 2024

No change for me with the beta version. I use the "convert ==highlights== to clozes" function, and created 20 flashcards earlier today, but none of them are getting picked up even with the new version

@ronzulu
Copy link
Collaborator

ronzulu commented Mar 26, 2024

@Effeh

Could you please post (as attachment, not copy/paste) a markdown file that contains flashcard(s) that don't appear in the review modal.

Also, please attach the plugin's settings file, located e.g.
D:\Obsidian\.obsidian\plugins\obsidian-spaced-repetition\data.json

@lukeh2313
Copy link

I am also having the same issue, only one deck of my 7-8 decks are showing up with no change after trying your beta version.

Edition Windows 10 Home
OS build 19045.4170

Obsidian version: 1.5.11

Plugin version: 1.12.1

Example note that doesn't show up: dividends vs share repurchases.md

Data: data.json

Thanks for the support!

@Effeh
Copy link

Effeh commented Mar 26, 2024 •
edited
Loading

Requested files for @ronzulu

same OS/versions as lukeh

This Is My Body.md
data.json

@ronzulu
Copy link
Collaborator

ronzulu commented Mar 26, 2024

Hi @Effeh

Your issue may appear the same as others on this topic, but actually is different.

There is a blank line at the very start of your file, i.e. line (1) in the following:

image

This means that the tags: Chinese is not recognized by Obsidian as frontmatter.

Simply remove that blank line, and it should work.

After deleting the blank line, Obsidian recognizes this as frontmatter and renders that section in a special manner

image

@ronzulu
Copy link
Collaborator

ronzulu commented Mar 26, 2024

Hi @lukeh2313

There were significant code changes in plugin version 1.12 to support:

It didn't occur to me that someone might place the topic tag on the line immediately following the last line of a question, and I didn't code for it.

For example, you have:

Why might a company prefer to repurchase shares over the issuance of a dividend?
?
1. Avoids double taxation, first at a corporate level (dividends are not tax deductible) then at individual income tax level when dividends are distributed.
2. Share repurchases inflate EPS by reducing number of shares outstanding which may increase company share price.
3. Share repurchases signal to the market that management believes its shares are undervalued, which might be seen as a good signal.
4. Once dividends are started, they are typically expected to continue. Stopping dividend payments is seen very poorly by the markets and are interpreted as a sign of lower future profits.
#wsp-red <!--SR:!2024-03-26,1,210-->

It should work if you move the topic tag #wsp-red to before the question, e.g.:

#wsp-red
Why might a company prefer to repurchase shares over the issuance of a dividend?
?
1. Avoids double taxation, first at a corporate level (dividends are not tax deductible) then at individual income tax level when dividends are distributed.
2. Share repurchases inflate EPS by reducing number of shares outstanding which may increase company share price.
3. Share repurchases signal to the market that management believes its shares are undervalued, which might be seen as a good signal.
4. Once dividends are started, they are typically expected to continue. Stopping dividend payments is seen very poorly by the markets and are interpreted as a sign of lower future profits.
<!--SR:!2024-03-26,1,210-->

Cheers
Ronny

@bgreenawald
Copy link
Author

bgreenawald commented Mar 26, 2024 •
edited
Loading

Beta version fixed the issue for me. Thanks for the quick fix!

Best,
Ben

@Scicily
Copy link

Scicily commented Mar 26, 2024 via email

@lukeh2313
Copy link

Thanks Ronny, that is working now!

@Effeh
Copy link

Effeh commented Mar 26, 2024

Thanks Ron. Sorry about the confusion. I'm not sure how that happened---I've been using the same template file for quite a while, and the problem only cropped up very recently. All fixed now regardless

@ronzulu ronzulu mentioned this issue Mar 27, 2024
Merged
@huetruong
Copy link

I'm just coming here because all my cards doesn't show up even in 1.12.2.

Here's an example

AZ305ST1-Q60.md

@Scicily
Copy link

Scicily commented Mar 31, 2024 via email

@ronzulu
Copy link
Collaborator

ronzulu commented Mar 31, 2024

Hi @huetruong thanks for posting the markdown file.

Your specific issue is being addressed under [BUG] Unable to recognize multi-line card that begins immediately after the frontmatter's closing line

@Scicily There might be multiple reasons why you are experiencing this. Please post a markdown file that exhibits the problem (attach, don't copy/paste)

Cheers
Ronny

@huetruong
Copy link

@ronzulu Please don't strip away my special character I used to separate the paragraphs. The last time I used a space, " ", in a blank line, it was strip away with strip() to remove whitespace.

@ronzulu
Copy link
Collaborator

ronzulu commented Apr 1, 2024

Please don't strip away my special character I used to separate the paragraphs. The last time I used a space, " ", in a blank line, it was strip away with strip() to remove whitespace.

Hi @huetruong, is your comment related to this issue? If so, please give further explanation.

@Scicily
Copy link

Scicily commented Apr 1, 2024 via email

@huetruong
Copy link

@ronzulu Please don't strip away my special character I used to separate the paragraphs. The last time I used a space, " ", in a blank line, it was strip away with strip() to remove whitespace.

A few months ago, a trim function was introduced which broke my flashcards. Currently, I am using a zero-width character to prevent the trim function from deleting my intentionally added blank lines, which make the flashcards easier to read. I am requesting that you take note of this issue to ensure that it does not occur again in the future. I have attached an example that illustrates the way I use the zero width character.

az305st1-q60

@ronzulu
Copy link
Collaborator

ronzulu commented Apr 1, 2024

Hi @huetruong I would suggest you create a new discussion item, as this is not quite on topic.

I can put a comment in the code about this, please let us know what is the zero width character you are using.

longer term I think the solution will be something like:
[FEAT] Support multiline questions with blank lines in both the card front and back

Cheers
Ronny

@ronzulu
Copy link
Collaborator

ronzulu commented Apr 1, 2024

Hello, I am currently facing an issue where I cannot display the review cards correctly. Since I am using a Mac Sonoma version 14.4.1, I am not quite sure how to locate the MD file you mentioned. If possible, could you please instruct me on how to proceed? Thank you very much. Sincerely Scicily

Hi @Scicily

Sorry, I'm not a Mac person - don't know where Obsidian. As an idea, click on the "vault" icon. On a PC it looks like:
image

On the left hand side it shows the location on the vault in the file system, perhaps on your Mac it would give you a clue:
image

Also, when you say "cannot display the review cards correctly" is the card:

  1. Missing, or
  2. Present and does display, but displays incorrectly

If the card does display, but incorrectly, then please open a new issue, as this issue is for cards that have gone missing after the recent release.

Cheers
Ronny

@huetruong
Copy link

Hi @huetruong I would suggest you create a new discussion item, as this is not quite on topic.

I can put a comment in the code about this, please let us know what is the zero width character you are using.

longer term I think the solution will be something like: [FEAT] Support multiline questions with blank lines in both the card front and back

Cheers Ronny

I would definitely love to have that in the long term. Here is what I am using below as a work around.

https://www.groovypost.com/howto/type-zero-width-space/

@ronzulu
Copy link
Collaborator

ronzulu commented Apr 2, 2024 •
edited
Loading

Hi all

Beta release is now available. I've tested with most (if not all) of the files posted above and seems ok.

There is a file called main.js and style.css in this zip file
main_915C.zip

You will need to copy them to the obsidian plug-in folder, e.g.
D:\Obsidian\.obsidian\plugins\obsidian-spaced-repetition

Then reload the plug-in, or restart obsidian.

Any feedback appreciated.

Ronny

This was referenced Apr 2, 2024
Closed
Closed
@Scicily
Copy link

Scicily commented Apr 4, 2024 via email

@Garg0yle
Copy link

Garg0yle commented Apr 5, 2024

Hi all

Beta release is now available. I've tested with most (if not all) of the files posted above and seems ok.

There is a file called main.js and style.css in this zip file main_915C.zip

You will need to copy them to the obsidian plug-in folder, e.g. D:\Obsidian\.obsidian\plugins\obsidian-spaced-repetition

Then reload the plug-in, or restart obsidian.

Any feedback appreciated.

Ronny

Hi Ronny, this fixed the issue for me! Thanks so much for the work here.

@huetruong
Copy link

Hi all

Beta release is now available. I've tested with most (if not all) of the files posted above and seems ok.

There is a file called main.js and style.css in this zip file main_915C.zip

You will need to copy them to the obsidian plug-in folder, e.g. D:\Obsidian\.obsidian\plugins\obsidian-spaced-repetition

Then reload the plug-in, or restart obsidian.

Any feedback appreciated.

Ronny

I can confirm my issue is fixed.

@Scicily
Copy link

Scicily commented Apr 6, 2024 via email

@ronzulu ronzulu mentioned this issue Apr 9, 2024
Merged
@ronzulu
Copy link
Collaborator

ronzulu commented Apr 23, 2024

Fixed in release 1.12.4, closing this now.

@ronzulu ronzulu closed this as completed Apr 23, 2024
@Scicily
Copy link

Scicily commented Apr 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@bgreenawald @Garg0yle @huetruong @Effeh @ronzulu @Scicily @Yury-Dictum @lukeh2313