Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing flashcards (bug introduced in 1.12.0) #927

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

ronzulu
Copy link
Collaborator

@ronzulu ronzulu commented Apr 9, 2024

This fixes:

@st3v3nmw I've marked this as draft whilst waiting for final confirmation from user who raised issue #923

Also, probably there will be conflicts between this and PR #926.

If you approve and merge one of the PRs, then I'll "update from upstream master" on my branch related to the other PR and resolve any conflicts.

If you prefer a different method of resolving the anticipated conflicts, please let me know.

Cheers
Ronny

@ronzulu
Copy link
Collaborator Author

ronzulu commented Apr 14, 2024

Hi @st3v3nmw I haven't heard back from the OP of #923, but I have checked with the file he posted, and all ok.

Because it's an important fix, I don't want to delay any longer.

Cheers
Ronny

@ronzulu ronzulu marked this pull request as ready for review April 14, 2024 12:37
@st3v3nmw st3v3nmw merged commit 2e76981 into st3v3nmw:master Apr 18, 2024
1 check passed
@st3v3nmw
Copy link
Owner

Because it's an important fix, I don't want to delay any longer.

Released in v1.12.4, apologies for the delay

@ronzulu ronzulu deleted the bug-915-922-923-missing-cards branch August 7, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants