feat: extended card title #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 971e4af Author: Anna Zubenko <anna_zubenko@fastmail.com> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998) commit a89a818 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> commit 77f15e1 Author: Carlos Galdino <carloshsgaldino@gmail.com> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (st3v3nmw#947) Ignore notes due in the future. Fixes st3v3nmw#548 commit 83590be Author: Newdea <9208450+Newdea@users.noreply.github.com> Date: Sat Jul 20 15:10:57 2024 +0800 fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001) commit e3a0146 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (st3v3nmw#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (st3v3nmw#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (st3v3nmw#982) commit ca4c261 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat May 25 10:13:50 2024 +0200 Improved issue templates (st3v3nmw#963) * Replace bug_report with form instead of template * Replace feature_request with form instead of template * Fix linting commit 053da6a Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Fri May 24 19:59:06 2024 +0200 Update German localization (st3v3nmw#961) * Update German localization * Fix linting
st3v3nmw
approved these changes
Sep 22, 2024
|
Hi, everything is now resolved. |
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an extension to the displayed card title partly as described in issue #851.
I added this because sometimes one doesn't know how many cards are left to review and thus is discouraged to continue if the time one has is short, but if the user exactly knows how many cards are left, then one could guess how long it will take and just pull through with it.
Another good reason for this addition is that the card title will display more useful information in the random card mode.
Before:
It just displayed the current deck name and the number of cards left in it.
After (with random card random deck mode enabled):
In random mode it displays now the deck chosen, with the number of cards left and in the subtitle the deck out of which the card was drawn.
After (with sequential mode enabled):
In sequential mode the title will display the deck chosen, with the number of cards left and in the subtitle the number of subdecks, the current deck name and the number of cards left in it.