[FIX] Not scroll back to top after review #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronzulu
approved these changes
Jul 16, 2024
ronzulu
added
the
beta
ronzulu
added a commit
to ronzulu/obsidian-spaced-repetition
that referenced
this pull request
Jul 16, 2024
st3v3nmw#971 Squashed commit 7e568fb
KyleKlus
pushed a commit
to KyleKlus/obsidian-spaced-repetition
that referenced
this pull request
Jul 22, 2024
* Update deprecated function * Add scroll back to top * Fix linting
KyleKlus
pushed a commit
to KyleKlus/obsidian-spaced-repetition
that referenced
this pull request
Jul 22, 2024
* Update deprecated function * Add scroll back to top * Fix linting
KyleKlus
added a commit
to KyleKlus/obsidian-spaced-repetition
that referenced
this pull request
Jul 22, 2024
commit 971e4af Author: Anna Zubenko <anna_zubenko@fastmail.com> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998) commit a89a818 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> commit 77f15e1 Author: Carlos Galdino <carloshsgaldino@gmail.com> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (st3v3nmw#947) Ignore notes due in the future. Fixes st3v3nmw#548 commit 83590be Author: Newdea <9208450+Newdea@users.noreply.github.com> Date: Sat Jul 20 15:10:57 2024 +0800 fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001) commit e3a0146 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (st3v3nmw#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (st3v3nmw#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (st3v3nmw#982) commit ca4c261 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat May 25 10:13:50 2024 +0200 Improved issue templates (st3v3nmw#963) * Replace bug_report with form instead of template * Replace feature_request with form instead of template * Fix linting commit 053da6a Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Fri May 24 19:59:06 2024 +0200 Update German localization (st3v3nmw#961) * Update German localization * Fix linting
ronzulu
added a commit
to ronzulu/obsidian-spaced-repetition
that referenced
this pull request
Jul 24, 2024
commit 3228e9c Author: Ronny Zulaikha <75528127+ronzulu@users.noreply.github.com> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (st3v3nmw#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <anna_zubenko@fastmail.com> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998) commit a89a818 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> commit 77f15e1 Author: Carlos Galdino <carloshsgaldino@gmail.com> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (st3v3nmw#947) Ignore notes due in the future. Fixes st3v3nmw#548 commit 83590be Author: Newdea <9208450+Newdea@users.noreply.github.com> Date: Sat Jul 20 15:10:57 2024 +0800 fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001) commit e3a0146 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (st3v3nmw#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (st3v3nmw#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (st3v3nmw#982)
ronzulu
added a commit
to ronzulu/obsidian-spaced-repetition
that referenced
this pull request
Aug 7, 2024
commit efebbd4 Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Wed Aug 7 15:21:28 2024 +1000 Added section: Displaying the Note Review Queue commit 7b0ae5b Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Thu Aug 1 12:11:38 2024 +1000 Minor commit a6046c1 Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Tue Jul 30 22:45:07 2024 +1000 Don't format/lint docs - it can mess up formatting of markdown commit eaba4d5 Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Tue Jul 30 22:24:39 2024 +1000 Ready for review commit 182c8b7 Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Tue Jul 30 12:16:39 2024 +1000 Minor renaming commit a44a623 Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Tue Jul 30 12:06:32 2024 +1000 Restructure continued commit d8da4be Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Tue Jul 30 11:50:12 2024 +1000 Folder restructure - moved contents of docs into new folder docs/docs etc (no change in content) commit 3a7457b Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Tue Jul 30 11:38:03 2024 +1000 Progress commit 274a970 Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Mon Jul 29 19:05:41 2024 +1000 Progress commit f6071ae Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Sun Jul 28 22:55:37 2024 +1000 Progress commit 66ec4c8 Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Sat Jul 27 15:37:16 2024 +1000 Progress commit 7871d34 Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Sat Jul 27 11:27:50 2024 +1000 Added a small vault used to generate screenshots for the user guide commit 318a571 Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Fri Jul 26 15:35:03 2024 +1000 Progress commit f7babfd Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Fri Jul 26 12:55:13 2024 +1000 Progress commit 337f175 Author: ronzulu <75528127+ronzulu@users.noreply.github.com> Date: Thu Jul 25 22:53:10 2024 +1000 Progress commit 3228e9c Author: Ronny Zulaikha <75528127+ronzulu@users.noreply.github.com> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (st3v3nmw#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <anna_zubenko@fastmail.com> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998) commit a89a818 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> commit 77f15e1 Author: Carlos Galdino <carloshsgaldino@gmail.com> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (st3v3nmw#947) Ignore notes due in the future. Fixes st3v3nmw#548 commit 83590be Author: Newdea <9208450+Newdea@users.noreply.github.com> Date: Sat Jul 20 15:10:57 2024 +0800 fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001) commit e3a0146 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (st3v3nmw#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (st3v3nmw#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (st3v3nmw#982)
ronzulu
added a commit
that referenced
this pull request
Sep 2, 2024
… info, and diff SR algorithms (#1006) * Perhaps half way towards implementation; doesn't build yet * Implemented 70%; doesn't build * Progress * Progress * Progress * 11 of the 19 existing test suites pass * 12 of the 19 existing test suites pass * 14 of the 19 existing test suites pass * Progress * 15 of the 19 existing test suites pass * All nineteen existing test suites pass * Minor fixes * More refactoring; doesn't build * Progress, doesn't build * Builds and all existing unit tests pass * Progress * Merge remote-tracking branch 'upstream/master'; due to conflicts fair manual work involved to complete merge with unit test cases working * Continued fixing post #495 integration * Added some test cases for OsrCore * Added unit test support code * Added more test files * Added test case, fixed code issues * Updated tests * Small refactor * !!GitHub_Desktop<feat-878-support-multiple-schedule-methods> * Fixes post merge stash * Added tests * More refactoring * Improved test coverage * Improved unit test code coverage * Starting testing of plugin within Obsidian * Bug fixes * Fixed broken test cases * Added test case for global coverage * A few merge fixes * Version ready for beta testing * Format and lint * Updated actions/checkout@v3 to node 20 * Lets make lint happy! * Previously the pnpm format added a blank line in a test markdown file which caused the test to fail * Slightly reduced jest code coverage threshold to writing a number of difficult test cases * Fixed bug where note frontmatter interval/ease set to null (app specific code, not core code) * Fixed some note review queue bugs (previously introduced in branch #878) * Lint & format * Fixed bug preventing stats being shown (previously introduced in branch #878) * Squashed commit of the following: commit 3228e9c Author: Ronny Zulaikha <75528127+ronzulu@users.noreply.github.com> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <anna_zubenko@fastmail.com> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (#998) commit a89a818 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> commit 77f15e1 Author: Carlos Galdino <carloshsgaldino@gmail.com> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (#947) Ignore notes due in the future. Fixes #548 commit 83590be Author: Newdea <9208450+Newdea@users.noreply.github.com> Date: Sat Jul 20 15:10:57 2024 +0800 fix #1000 sidebar indent (#1001) commit e3a0146 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (#982) * Format & lint * fix: changelog formatting * Post review fixes * Format and lint * Format & lint --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com>
st3v3nmw
added a commit
that referenced
this pull request
Sep 21, 2024
… info, and diff SR algorithms (#1006) * Perhaps half way towards implementation; doesn't build yet * Implemented 70%; doesn't build * Progress * Progress * Progress * 11 of the 19 existing test suites pass * 12 of the 19 existing test suites pass * 14 of the 19 existing test suites pass * Progress * 15 of the 19 existing test suites pass * All nineteen existing test suites pass * Minor fixes * More refactoring; doesn't build * Progress, doesn't build * Builds and all existing unit tests pass * Progress * Merge remote-tracking branch 'upstream/master'; due to conflicts fair manual work involved to complete merge with unit test cases working * Continued fixing post #495 integration * Added some test cases for OsrCore * Added unit test support code * Added more test files * Added test case, fixed code issues * Updated tests * Small refactor * !!GitHub_Desktop<feat-878-support-multiple-schedule-methods> * Fixes post merge stash * Added tests * More refactoring * Improved test coverage * Improved unit test code coverage * Starting testing of plugin within Obsidian * Bug fixes * Fixed broken test cases * Added test case for global coverage * A few merge fixes * Version ready for beta testing * Format and lint * Updated actions/checkout@v3 to node 20 * Lets make lint happy! * Previously the pnpm format added a blank line in a test markdown file which caused the test to fail * Slightly reduced jest code coverage threshold to writing a number of difficult test cases * Fixed bug where note frontmatter interval/ease set to null (app specific code, not core code) * Fixed some note review queue bugs (previously introduced in branch #878) * Lint & format * Fixed bug preventing stats being shown (previously introduced in branch #878) * Squashed commit of the following: commit 3228e9c Author: Ronny Zulaikha <75528127+ronzulu@users.noreply.github.com> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <anna_zubenko@fastmail.com> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (#998) commit a89a818 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> commit 77f15e1 Author: Carlos Galdino <carloshsgaldino@gmail.com> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (#947) Ignore notes due in the future. Fixes #548 commit 83590be Author: Newdea <9208450+Newdea@users.noreply.github.com> Date: Sat Jul 20 15:10:57 2024 +0800 fix #1000 sidebar indent (#1001) commit e3a0146 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (#982) * Format & lint * fix: changelog formatting * Post review fixes * Format and lint * Format & lint --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com>
st3v3nmw
added a commit
that referenced
this pull request
Sep 21, 2024
… info, and diff SR algorithms (#1006) * Perhaps half way towards implementation; doesn't build yet * Implemented 70%; doesn't build * Progress * Progress * Progress * 11 of the 19 existing test suites pass * 12 of the 19 existing test suites pass * 14 of the 19 existing test suites pass * Progress * 15 of the 19 existing test suites pass * All nineteen existing test suites pass * Minor fixes * More refactoring; doesn't build * Progress, doesn't build * Builds and all existing unit tests pass * Progress * Merge remote-tracking branch 'upstream/master'; due to conflicts fair manual work involved to complete merge with unit test cases working * Continued fixing post #495 integration * Added some test cases for OsrCore * Added unit test support code * Added more test files * Added test case, fixed code issues * Updated tests * Small refactor * !!GitHub_Desktop<feat-878-support-multiple-schedule-methods> * Fixes post merge stash * Added tests * More refactoring * Improved test coverage * Improved unit test code coverage * Starting testing of plugin within Obsidian * Bug fixes * Fixed broken test cases * Added test case for global coverage * A few merge fixes * Version ready for beta testing * Format and lint * Updated actions/checkout@v3 to node 20 * Lets make lint happy! * Previously the pnpm format added a blank line in a test markdown file which caused the test to fail * Slightly reduced jest code coverage threshold to writing a number of difficult test cases * Fixed bug where note frontmatter interval/ease set to null (app specific code, not core code) * Fixed some note review queue bugs (previously introduced in branch #878) * Lint & format * Fixed bug preventing stats being shown (previously introduced in branch #878) * Squashed commit of the following: commit 3228e9c Author: Ronny Zulaikha <75528127+ronzulu@users.noreply.github.com> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <anna_zubenko@fastmail.com> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (#998) commit a89a818 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> commit 77f15e1 Author: Carlos Galdino <carloshsgaldino@gmail.com> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (#947) Ignore notes due in the future. Fixes #548 commit 83590be Author: Newdea <9208450+Newdea@users.noreply.github.com> Date: Sat Jul 20 15:10:57 2024 +0800 fix #1000 sidebar indent (#1001) commit e3a0146 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (#982) * Format & lint * fix: changelog formatting * Post review fixes * Format and lint * Format & lint --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com>
st3v3nmw
added a commit
that referenced
this pull request
Sep 21, 2024
* Full coverage for UnitTest utils * Change test config * Added Unit Test for stats * Added Unit Test for NumberCountDict * Add function parseDateToTicks, formatDate * Fix includes and doc * Added Testcases * Remove unused function * Try fix ticksFromDate * Fix lint * [FIX] isEqualOrSubPath function (#1048) * Improve isEqualOrSubPath Description + remove use of normalize * update changelog * fix linting * update changelog * Revert "update changelog" This reverts commit d7ba801. * Update Changelog * feat: refactor code to support diff methods of storing the scheduling info, and diff SR algorithms (#1006) * Perhaps half way towards implementation; doesn't build yet * Implemented 70%; doesn't build * Progress * Progress * Progress * 11 of the 19 existing test suites pass * 12 of the 19 existing test suites pass * 14 of the 19 existing test suites pass * Progress * 15 of the 19 existing test suites pass * All nineteen existing test suites pass * Minor fixes * More refactoring; doesn't build * Progress, doesn't build * Builds and all existing unit tests pass * Progress * Merge remote-tracking branch 'upstream/master'; due to conflicts fair manual work involved to complete merge with unit test cases working * Continued fixing post #495 integration * Added some test cases for OsrCore * Added unit test support code * Added more test files * Added test case, fixed code issues * Updated tests * Small refactor * !!GitHub_Desktop<feat-878-support-multiple-schedule-methods> * Fixes post merge stash * Added tests * More refactoring * Improved test coverage * Improved unit test code coverage * Starting testing of plugin within Obsidian * Bug fixes * Fixed broken test cases * Added test case for global coverage * A few merge fixes * Version ready for beta testing * Format and lint * Updated actions/checkout@v3 to node 20 * Lets make lint happy! * Previously the pnpm format added a blank line in a test markdown file which caused the test to fail * Slightly reduced jest code coverage threshold to writing a number of difficult test cases * Fixed bug where note frontmatter interval/ease set to null (app specific code, not core code) * Fixed some note review queue bugs (previously introduced in branch #878) * Lint & format * Fixed bug preventing stats being shown (previously introduced in branch #878) * Squashed commit of the following: commit 3228e9c Author: Ronny Zulaikha <75528127+ronzulu@users.noreply.github.com> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <anna_zubenko@fastmail.com> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (#998) commit a89a818 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> commit 77f15e1 Author: Carlos Galdino <carloshsgaldino@gmail.com> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (#947) Ignore notes due in the future. Fixes #548 commit 83590be Author: Newdea <9208450+Newdea@users.noreply.github.com> Date: Sat Jul 20 15:10:57 2024 +0800 fix #1000 sidebar indent (#1001) commit e3a0146 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (#982) * Format & lint * fix: changelog formatting * Post review fixes * Format and lint * Format & lint --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> * chore: update dependencies, linting, & tests * update eslint * lower coverage threshold * minor fixes --------- Co-authored-by: 4Source <38220764+4Source@users.noreply.github.com> Co-authored-by: Ronny Zulaikha <75528127+ronzulu@users.noreply.github.com>
st3v3nmw
pushed a commit
that referenced
this pull request
Sep 23, 2024
* UPDATE: Extended the amount of information in the card title * UPDATE: Improved card title in random mode * UPDATE: Documented changes & formatted with prettier * Squashed commit of the following: commit 971e4af Author: Anna Zubenko <anna_zubenko@fastmail.com> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (#998) commit a89a818 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> commit 77f15e1 Author: Carlos Galdino <carloshsgaldino@gmail.com> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (#947) Ignore notes due in the future. Fixes #548 commit 83590be Author: Newdea <9208450+Newdea@users.noreply.github.com> Date: Sat Jul 20 15:10:57 2024 +0800 fix #1000 sidebar indent (#1001) commit e3a0146 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (#982) commit ca4c261 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat May 25 10:13:50 2024 +0200 Improved issue templates (#963) * Replace bug_report with form instead of template * Replace feature_request with form instead of template * Fix linting commit 053da6a Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Fri May 24 19:59:06 2024 +0200 Update German localization (#961) * Update German localization * Fix linting * UPDATE: Quick clean up of unused code * UPDATE: Added changelog message again * UPDATE: Executed format script --------- Co-authored-by: Kyle Klus <kyle.klus@f-i.de>
Newdea
pushed a commit
to open-spaced-repetition/obsidian-spaced-repetition-recall
that referenced
this pull request
Sep 25, 2024
* Full coverage for UnitTest utils * Change test config * Added Unit Test for stats * Added Unit Test for NumberCountDict * Add function parseDateToTicks, formatDate * Fix includes and doc * Added Testcases * Remove unused function * Try fix ticksFromDate * Fix lint * [FIX] isEqualOrSubPath function (st3v3nmw#1048) * Improve isEqualOrSubPath Description + remove use of normalize * update changelog * fix linting * update changelog * Revert "update changelog" This reverts commit d7ba801. * Update Changelog * feat: refactor code to support diff methods of storing the scheduling info, and diff SR algorithms (st3v3nmw#1006) * Perhaps half way towards implementation; doesn't build yet * Implemented 70%; doesn't build * Progress * Progress * Progress * 11 of the 19 existing test suites pass * 12 of the 19 existing test suites pass * 14 of the 19 existing test suites pass * Progress * 15 of the 19 existing test suites pass * All nineteen existing test suites pass * Minor fixes * More refactoring; doesn't build * Progress, doesn't build * Builds and all existing unit tests pass * Progress * Merge remote-tracking branch 'upstream/master'; due to conflicts fair manual work involved to complete merge with unit test cases working * Continued fixing post st3v3nmw#495 integration * Added some test cases for OsrCore * Added unit test support code * Added more test files * Added test case, fixed code issues * Updated tests * Small refactor * !!GitHub_Desktop<feat-878-support-multiple-schedule-methods> * Fixes post merge stash * Added tests * More refactoring * Improved test coverage * Improved unit test code coverage * Starting testing of plugin within Obsidian * Bug fixes * Fixed broken test cases * Added test case for global coverage * A few merge fixes * Version ready for beta testing * Format and lint * Updated actions/checkout@v3 to node 20 * Lets make lint happy! * Previously the pnpm format added a blank line in a test markdown file which caused the test to fail * Slightly reduced jest code coverage threshold to writing a number of difficult test cases * Fixed bug where note frontmatter interval/ease set to null (app specific code, not core code) * Fixed some note review queue bugs (previously introduced in branch st3v3nmw#878) * Lint & format * Fixed bug preventing stats being shown (previously introduced in branch st3v3nmw#878) * Squashed commit of the following: commit 3228e9c Author: Ronny Zulaikha <75528127+ronzulu@users.noreply.github.com> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (st3v3nmw#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <anna_zubenko@fastmail.com> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998) commit a89a818 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> commit 77f15e1 Author: Carlos Galdino <carloshsgaldino@gmail.com> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (st3v3nmw#947) Ignore notes due in the future. Fixes st3v3nmw#548 commit 83590be Author: Newdea <9208450+Newdea@users.noreply.github.com> Date: Sat Jul 20 15:10:57 2024 +0800 fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001) commit e3a0146 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (st3v3nmw#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (st3v3nmw#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <38220764+4Source@users.noreply.github.com> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <41666068+artefaritaKuniklo@users.noreply.github.com> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (st3v3nmw#982) * Format & lint * fix: changelog formatting * Post review fixes * Format and lint * Format & lint --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com> * chore: update dependencies, linting, & tests * update eslint * lower coverage threshold * minor fixes --------- Co-authored-by: 4Source <38220764+4Source@users.noreply.github.com> Co-authored-by: Ronny Zulaikha <75528127+ronzulu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #966
Scroll back after review card done. Required for longer cards or small screens.