Use Poetry in build scripts and CI #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
approved these changes
Jul 20, 2021
.github/workflows/release.yml
Outdated
| @@ -20,11 +20,11 @@ jobs: | |||
| - name: Install release dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install setuptools wheel twine | |||
| pip install poetry | |||
There was a problem hiding this comment.
Might make sense to lock the version of poetry used here?
|
I've merged in the work from #25 into this PR. A push of the v0.2.8 tag from this branch successfully pushed pypgstac 0.2.8 up to pypi as well as a v0.2.8 docker image up to ghcr.io |
siiiick. Love when things work as intended :-) |
|
Hey @lossyrob can I get a review posted on this so I can merge it? |
lossyrob
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove remnants (setup.py, requirements-dev.txt) and use Poetry for all builds and for pushing to PyPi.
Fixes #21
Add release trigger for git tags that creates a release from Tags and also posts docker image to ghcr.io
Fixes #25
Fixes #19
Fixes #6