Feature/update Collection extent from Items #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2020 14:07
…ses bbox and datetime | props.star_datetime | props.end_datetime
lossyrob
requested changes
Aug 20, 2020
There was a problem hiding this comment.
Looking great.
Two small changes, otherwise this is good to go:
- Can you name the PR with a more descriptive name?
- Can you add a CHANGELOG.md item? It would go in the same place as the commit here, including a link to this PR. I'll wait to merge that PR until after this to avoid conflicts.
Thanks!
| @@ -202,6 +202,37 @@ def from_dict(cls, d, href=None, root=None): | |||
|
|
|||
| return collection | |||
|
|
|||
| def update_extent_from_items(self): | |||
There was a problem hiding this comment.
Thanks, I have updated the changelog as well.
gwnoseworthy
changed the title
lossyrob
approved these changes
Aug 20, 2020
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method to update collection extent object.
creates SpatialExtent based on bbox of items
creates Temporal Extent based on datetime + props.start_datetime, props.end_datetime
Impliments #145