Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move db credentials into a secret #557

Merged
merged 6 commits into from
May 22, 2024

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented May 7, 2024

Description

fixes #352

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@adwk67 adwk67 marked this pull request as ready for review May 7, 2024 10:10
@maltesander maltesander self-requested a review May 10, 2024 06:57
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking and a question, LGTM otherwise!

CHANGELOG.md Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
@maltesander maltesander added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. changelog/crd-change labels May 10, 2024
@adwk67
Copy link
Member Author

adwk67 commented May 21, 2024

Local tests:

--- PASS: kuttl (4735.62s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/oidc_druid-latest-28.0.1_zookeeper-latest-3.9.2_s3-use-tls-true_openshift-false (475.44s)
        --- PASS: kuttl/harness/cluster-operation_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-latest-3.3.6_openshift-false (643.17s)
        --- PASS: kuttl/harness/tls_druid-latest-28.0.1_zookeeper-latest-3.9.2_tls-mode-internal-and-server-tls_openshift-false (354.22s)
        --- PASS: kuttl/harness/ldap-authentication_druid-28.0.1_zookeeper-latest-3.9.2_opa-0.61.0_hadoop-latest-3.3.6_ldap-use-tls-true_ldap-no-bind-credentials-false_openshift-false (261.79s)
        --- PASS: kuttl/harness/authorizer_druid-28.0.1_zookeeper-latest-3.9.2_opa-0.61.0_hadoop-3.3.6_openshift-false (287.51s)
        --- PASS: kuttl/harness/ingestion-s3-ext_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-3.3.6_openshift-false (335.59s)
        --- PASS: kuttl/harness/logging_druid-28.0.1_zookeeper-latest-3.9.2_hadoop-3.3.6_openshift-false (319.82s)
        --- PASS: kuttl/harness/s3-deep-storage_druid-latest-28.0.1_zookeeper-latest-3.9.2_s3-use-tls-true_openshift-false (240.04s)
        --- PASS: kuttl/harness/tls_druid-latest-28.0.1_zookeeper-latest-3.9.2_tls-mode-no-tls_openshift-false (227.01s)
        --- PASS: kuttl/harness/orphaned-resources_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-3.3.6_openshift-false (338.17s)
        --- PASS: kuttl/harness/tls_druid-latest-28.0.1_zookeeper-latest-3.9.2_tls-mode-internal-and-server-tls-and-tls-client-auth_openshift-false (302.12s)
        --- PASS: kuttl/harness/ingestion-no-s3-ext_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-3.3.6_openshift-false (248.79s)
        --- PASS: kuttl/harness/smoke_druid-28.0.1_zookeeper-3.8.3_hadoop-3.3.6_openshift-false (284.56s)
        --- PASS: kuttl/harness/resources_druid-latest-28.0.1_zookeeper-latest-3.9.2_openshift-false (110.81s)
        --- PASS: kuttl/harness/hdfs-deep-storage_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-3.3.6_openshift-false (305.93s)

@adwk67
Copy link
Member Author

adwk67 commented May 21, 2024

@adwk67 adwk67 requested a review from maltesander May 21, 2024 12:59
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67 adwk67 added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 2e6dcf0 May 22, 2024
32 checks passed
@adwk67 adwk67 deleted the fix/use-secret-for-db-credentials branch May 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Database config to a secret
2 participants