Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move metastore db credentials into a secret #452

Merged
merged 9 commits into from
May 16, 2024
Merged

fix: move metastore db credentials into a secret #452

merged 9 commits into from
May 16, 2024

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented May 2, 2024 •
edited
Loading

Description

Fixes: #148
Jenkins 🟢 https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hive-operator-it-custom/56/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

Acceptance
Preview Give feedback

@adwk67 adwk67 marked this pull request as ready for review May 2, 2024 15:46
@maltesander maltesander self-requested a review May 10, 2024 06:41
maltesander
maltesander requested changes May 10, 2024
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicking, LGTM otherwise!

rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
tests/templates/kuttl/cluster-operation/10-install-hive.yaml.j2 Outdated Show resolved Hide resolved
tests/templates/kuttl/smoke/60-install-hive.yaml.j2 Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@maltesander maltesander added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. changelog/crd-change labels May 10, 2024
adwk67 and others added 4 commits May 13, 2024 09:54
@adwk67 @maltesander
Update rust/operator-binary/src/controller.rs
ad9dbe9 
Co-authored-by: Malte Sander <contact@maltesander.com>
@adwk67 @maltesander
Update CHANGELOG.md
50be4d4 
Co-authored-by: Malte Sander <contact@maltesander.com>
@adwk67
consistent ordering
67ed2e0
@adwk67
Merge branch 'main' into fix/use-secret-for-db-credentials
0830da9
@adwk67 adwk67 requested a review from maltesander May 13, 2024 09:49
maltesander
maltesander approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67 adwk67 enabled auto-merge May 16, 2024 14:53
@adwk67 adwk67 added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 2eb3f97 May 16, 2024
32 checks passed
@adwk67 adwk67 deleted the fix/use-secret-for-db-credentials branch May 16, 2024 15:22
@adwk67 adwk67 mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Database config to a secret
2 participants
@adwk67 @maltesander