Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stackable-telemetry): Add tuple to settings conversions #940

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

Techassi
Copy link
Member

Part of stackabletech/issues#639

This adds conversions to turn (&'static str, LevelFilter) and (&'static str, LevelFilter, bool) into subscriber settings.

@NickLarsenNZ
Copy link
Member

Linking prior art: 51ae3ed

@Techassi Techassi marked this pull request as ready for review January 16, 2025 15:31
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 68acaaf Jan 17, 2025
10 checks passed
@Techassi Techassi deleted the feat/stackable-telemetry-tuples branch January 17, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

2 participants