Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nix bash script #325

Merged
merged 5 commits into from
Feb 21, 2024
Merged

fix: nix bash script #325

merged 5 commits into from
Feb 21, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Feb 21, 2024 •
edited
Loading

  • add shebang to nix bash script (github actions runs sh by default, and we need set -o pipefail.
  • add a dry-run workflow input so we can test things without raising a million PRs

image

@NickLarsenNZ NickLarsenNZ self-assigned this Feb 21, 2024
@NickLarsenNZ
Copy link
Member Author

Tested with:

❯ nix build -f. regenerateNixLockfiles && cat result/bin/regenerate-nix-lockfiles
#!/usr/bin/env bash
set -euo pipefail
echo Running crate2nix
/nix/store/2imrbnjq2q6ix6ay8nd20zxklyxhm17p-rust_crate2nix-0.11.1/bin/crate2nix generate
❯ sh 
sh-5.2$ ./result/bin/regenerate-nix-lockfiles
Running crate2nix
Generated ./Cargo.nix successfully.

@NickLarsenNZ NickLarsenNZ requested a review from nightkr February 21, 2024 16:20
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit c745fb2 Feb 21, 2024
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the ci/fix-nix-bash-script branch February 21, 2024 16:22
NickLarsenNZ added a commit to stackabletech/stackable-cockpit that referenced this pull request Mar 4, 2024
@NickLarsenNZ
fix(nix): add shebang to script (stackabletech/operator-templating#325)
4d6ed4b
NickLarsenNZ added a commit to stackabletech/stackable-cockpit that referenced this pull request Mar 4, 2024
@NickLarsenNZ
fix(nix): add shebang to script (stackabletech/operator-templating#325)
169da22
github-merge-queue bot pushed a commit to stackabletech/stackable-cockpit that referenced this pull request Mar 4, 2024
@NickLarsenNZ
ci: Fork awareness (#214)
c613649 
* ci(cockpit): use install-nix-action

* fix(nix): add shebang to script (stackabletech/operator-templating#325)

* ci(cockpit): separate build/publish steps so that fork PRs don't fail on publish

* chore: remove old BORS message from PR tempate
github-merge-queue bot pushed a commit to stackabletech/stackable-cockpit that referenced this pull request Mar 20, 2024
@nightkr @NickLarsenNZ
feat: Add experimental debug container command (#204)
3730ed3 
* Basic ability to create and attach a debug container

* Add support for copying env from a target container, as well as running a custom command

* Send TTY window size

* Read asynchronously from stdin

* Default to the default namespace

* Fix stdin not being re-registered correctly with the waker

* Add debug error messages

* Let AsyncStdin reset its state once shut down

* Docs, demarcate as experimental

* Move debug container name to span

* Changelog

* ci: use install-nix-action

* fix(nix): add shebang to script (stackabletech/operator-templating#325)

* Move dependencies into root Cargo.toml

* Uglify formatting

* Change the container prefix from sble-debug- to stackablectl-debug-

* Default to the target container's image

* Run debug container as root

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickLarsenNZ @nightkr