-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add experimental debug container command #204
Conversation
|
This is intentionally not part of the cockpit library since it's experimental and assumes that it's running in its own TTY. It could be factored out into a library component but I don't think it's super valuable to do preemptively. |
@nightkr, forgive my meddling. Was just trying to get the workflows to pass, so I added a couple of commits which were ultimately unnecessary as I backported some other changes to main which required those same two changes for the workflow to pass (I think). So, those two changes came in via the latest merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round, mostly looking good!
Description
Adds a
stackablectl experimental-debug
command that creates and attaches a debug container. Compared tokubectl debug
it should also (at least) mount in volumes and environment variables from the container being debugged.Fixes #201.
Definition of Done Checklist
Author
Reviewer
Acceptance
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information