Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump to operator-rs 0.84.0 #690

Closed
wants to merge 5 commits into from
Closed

chore: Bump to operator-rs 0.84.0 #690

wants to merge 5 commits into from

Conversation

sbernauer
Copy link
Member

Description

Draft to test stackabletech/operator-rs#938

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two small suggestions.

rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/main.rs Show resolved Hide resolved
@sbernauer
Copy link
Member Author

Pls watch out, I switched out to for_each_concurrent, happy about feedback. Given we tokio::spawned before (see stackabletech/operator-rs#938) I think concurrency (not parallelism) is good

@sbernauer sbernauer requested a review from Techassi January 10, 2025 08:09
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the patch needs to be removed before merging.

@sbernauer
Copy link
Member Author

Changes incorporated into #677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants