Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Bump Rust dependencies, support k8s 1.32 #938

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 8, 2025

Description

Example implementation: stackabletech/trino-operator#690

kube 0.98.0 introduced a breaking change, which we propagate to client crates.
See the CHANGELOG for details

Before

§ kubectl describe trino simple-trino
# [...]
Type     Reason                Age   From                               Message
----     ------                ----  ----                               -------
Warning  InvalidProductConfig  41s   trinocluster.trino.stackable.tech  invalid product config: invalid configuration found: failed to parse 'XXXXX.0.0' as SemVer version: unexpected character 'X' while parsing major version number
Warning  InvalidProductConfig  81s   trinocluster.trino.stackable.tech  invalid product config: invalid configuration found: failed to parse 'XXXXX.0.0' as SemVer version: unexpected character 'X' while parsing major version number
Warning  InvalidProductConfig  51s   trinocluster.trino.stackable.tech  invalid product config: invalid configuration found: failed to parse 'XXXXX.0.0' as SemVer version: unexpected character 'X' while parsing major version number

After

Type     Reason                Age               From                               Message
----     ------                ----              ----                               -------
Warning  InvalidProductConfig  1s (x5 over 21s)  trinocluster.trino.stackable.tech  invalid product config: invalid configuration found: failed to parse 'XXXXX.0.0' as SemVer version: unexpected character 'X' while parsing major version number

Leftovers

$ cargo +nightly update -Z unstable-options --breaking --dry-run                                                            kind-kind
    Updating crates.io index
   Upgrading opentelemetry_sdk ^0.23.0 -> ^0.27.1
   Upgrading tracing-opentelemetry ^0.24.0 -> ^0.28.0
   Upgrading opentelemetry ^0.23.0 -> ^0.27.1
   Upgrading opentelemetry-appender-tracing ^0.4.0 -> ^0.27.0
   Upgrading opentelemetry-otlp ^0.16.0 -> ^0.27.0
   Upgrading opentelemetry-semantic-conventions ^0.15.0 -> ^0.27.0

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@sbernauer sbernauer self-assigned this Jan 8, 2025
@sbernauer sbernauer changed the title chore: Bump Rust dependecies and support k8s 1.32 chore!: Bump Rust dependecies and support k8s 1.32 Jan 8, 2025
@sbernauer sbernauer changed the title chore!: Bump Rust dependecies and support k8s 1.32 chore!: Bump Rust dependecies, support k8s 1.32 and aggregate Events Jan 8, 2025
@sbernauer sbernauer changed the title chore!: Bump Rust dependecies, support k8s 1.32 and aggregate Events chore!: Bump Rust dependecies, support k8s 1.32 Jan 8, 2025
@Techassi Techassi self-requested a review January 8, 2025 16:01
@sbernauer sbernauer changed the title chore!: Bump Rust dependecies, support k8s 1.32 chore!: Bump Rust dependencies, support k8s 1.32 Jan 9, 2025
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small suggestion for the changelog.

crates/stackable-operator/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Techassi <git@techassi.dev>
@sbernauer sbernauer requested a review from Techassi January 9, 2025 11:55
@sbernauer sbernauer added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 29e920d Jan 9, 2025
10 checks passed
@sbernauer sbernauer deleted the chore/bumps-4 branch January 9, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants