Add ansible-lint CI #1368
Open
Add ansible-lint CI #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to install the role anywhere.
Alex-Welsh
force-pushed
the
2024.1-ansible-lint-alex
branch
6 times, most recently
from
6679b59 to
05ff525
Compare
This commit includes a properly configured ansible-lint CI job and a large amount of changes to the existing playbooks so that the new CI passes. Some fixes were applied automatically with the --fix argument, many were made manually. There is some risk that the changes have altered the behaviour of the playbooks.
Alex-Welsh
force-pushed
the
2024.1-ansible-lint-alex
branch
from
05ff525 to
0be7a56
Compare
Closed
jovial
reviewed
Nov 7, 2024
MoteHue
reviewed
Nov 7, 2024
Alex-Welsh
force-pushed
the
2024.1-ansible-lint-alex
branch
from
61edbbc to
321acad
Compare
MoteHue
requested changes
Nov 13, 2024
seunghun1ee
requested changes
Nov 14, 2024
Alex-Welsh
added
stackhpc-ci
Alex-Welsh
force-pushed
the
2024.1-ansible-lint-alex
branch
from
ff3fd29 to
c81275f
Compare
Co-authored-by: Matt Crees <mattc@stackhpc.com>
seunghun1ee
previously approved these changes
Dec 3, 2024
Alex-Welsh
added
workflows
Alex-Welsh
force-pushed
the
2024.1-ansible-lint-alex
branch
from
213d3c1 to
8c0039d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ansible-lint CI job.
The job itself is quite simple, however there are a lot of changes to get to pass. Many were fixed automatically by the linter (e.g. formatting). Others were fixed by hand (e.g. Task names). Some rules are skipped because they are not relevant