fix(255): push image to ghcr instead of docker hub #298
Conversation
|
@karl-johan-grahn Image is available for testing. |
|
@karl-johan-grahn Image is available for testing. |
|
@karl-johan-grahn Image is available for testing. |
|
@karl-johan-grahn Image is available for testing. |
|
@karl-johan-grahn Image is available for testing. |
|
Any update on this being merged? |
|
@karl-johan-grahn Image is available for testing. |
|
@rasheedamir can we get some traction on this? |
|
Any update on this? |
|
@karl-johan-grahn can you plz update so, we push to both dockerhub and ghcr? |
.github/workflows/push.yaml
Outdated
| @@ -83,11 +84,12 @@ jobs: | |||
| - name: Set up Docker Buildx | |||
| uses: docker/setup-buildx-action@v1 | |||
|
|
|||
| - name: Login to Registry | |||
| uses: docker/login-action@v1 | |||
| - name: Login to Docker registry ${{env.REGISTRY}} | |||
There was a problem hiding this comment.
Should we update name to 'Login to GHCR registry' or 'image registry'?
.github/workflows/pull_request.yaml
Outdated
| @@ -86,11 +87,12 @@ jobs: | |||
| - name: Set up Docker Buildx | |||
| uses: docker/setup-buildx-action@v1 | |||
|
|
|||
| - name: Login to Registry | |||
| uses: docker/login-action@v1 | |||
| - name: Login to Docker registry ${{env.REGISTRY}} | |||
There was a problem hiding this comment.
Should we update name to 'Login to GHCR registry' or 'image registry'?
|
Given the recent dockerhub announcement of removing free team orgs, I'm wondering if the current org will be affected? And if so perhaps this could finally have a high priority? |
|
@MahnoorAsghar can you please take this up? The chart also needs to be updated for this as we need to update the image repo. |
|
This should be considered a high priority unless your team is paying for Dockerhub. Can anyone take this over and see it to completion? According to the folks at Docker, you all have less than 30 days to figure out what to do if not paying for dockerhub. |
|
It seems that the situation changed (rollback of decision) : docker/hub-feedback#2314 (comment) |
|
It would still be nice to finally have this merged, to avoid things like running into rate limits. Also, the Docker organisation seems to become less and less reliable. |
|
I am pretty exhausted at this point of asking for this. What is the deal, is anyone maintaining this project anymore? Should we look for alternatives? |
|
@hussnain612 Yikes! You better fix it before anyone else finds out! Build has Failed! |
|
@hussnain612 Image is available for testing. |
|
@onedr0p sorry for the delay. This has been merged now. |
Fixes #255. This change will push the docker image to ghcr instead of docker hub to avoid rate limits, using the username of the user that initiated the workflow run and the secret that is automatically created for every workflow run.