Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(255): push image to ghcr instead of docker hub #298

Merged
merged 10 commits into from
Apr 5, 2023
Merged

fix(255): push image to ghcr instead of docker hub #298

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3b94615
fix(255): push image to ghcr instead of docker hub
Mar 21, 2022
cb39cf1
fix(255): update pr workflow too
Mar 21, 2022
a5bb039
fix(255): add registry var
Mar 21, 2022
77e2df9
fix(255): checkout does not work as expected
Mar 21, 2022
72ae858
fix(255): add back
Mar 21, 2022
2cca412
Merge branch 'master' into fix-255
karl-johan-grahn Jun 14, 2022
32ab2ad
Updated github actions to push to ghcr and dockerHub
hussnain612 Apr 5, 2023
3e88e06
Updated image path
hussnain612 Apr 5, 2023
aab8f66
Updated actions dependencies
hussnain612 Apr 5, 2023
ddbe303
Merge remote-tracking branch 'upstream/master' into fix-255
hussnain612 Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/pull_request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ env:
GOLANG_VERSION: 1.17.7
KUBERNETES_VERSION: "1.18.0"
KIND_VERSION: "0.10.0"
REGISTRY: ghcr.io

jobs:
build:
Expand Down Expand Up @@ -86,11 +87,12 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1

- name: Login to Registry
uses: docker/login-action@v1
- name: Login to Docker registry ${{env.REGISTRY}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update name to 'Login to GHCR registry' or 'image registry'?

uses: docker/login-action@v1.14.1
with:
username: ${{ secrets.STAKATER_DOCKERHUB_USERNAME }}
password: ${{ secrets.STAKATER_DOCKERHUB_PASSWORD }}
registry: ${{env.REGISTRY}}
username: ${{github.actor}}
password: ${{secrets.GITHUB_TOKEN}}

- name: Generate image repository path
run: |
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ env:
KUBERNETES_VERSION: "1.18.0"
KIND_VERSION: "0.10.0"
HELM_REGISTRY_URL: "https://stakater.github.io/stakater-charts"
REGISTRY: ghcr.io

jobs:
build:
Expand Down Expand Up @@ -83,11 +84,12 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1

- name: Login to Registry
uses: docker/login-action@v1
- name: Login to Docker registry ${{env.REGISTRY}}
Copy link
Contributor

@MahnoorAsghar MahnoorAsghar Feb 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update name to 'Login to GHCR registry' or 'image registry'?

uses: docker/login-action@v1.14.1
with:
username: ${{ secrets.STAKATER_DOCKERHUB_USERNAME }}
password: ${{ secrets.STAKATER_DOCKERHUB_PASSWORD }}
registry: ${{env.REGISTRY}}
username: ${{github.actor}}
password: ${{secrets.GITHUB_TOKEN}}

- name: Generate image repository path
run: |
Expand Down