-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow executing cmdstan through WSL #677
Conversation
Forgot to mention in the description - this PR also adds a Github actions workflow to run the unit tests under WSL as well |
WOW! This is awesome stuff and will be a huge benefit to Windows users! Fantastic! I am going to review this later today and tomorrow in detail, just a few questions so I know I am understanding this correctly:
Lastly, please add yourself to the list of contributors. |
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
- Coverage 91.86% 89.94% -1.93%
==========================================
Files 12 12
Lines 3540 3649 +109
==========================================
+ Hits 3252 3282 +30
- Misses 288 367 +79
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and just reviewed. Ignore my questions above, I think I got all the answers from the code. The code change looks great and the tests are passing in all OSes. I just want to take a few minutes to test it live on my Windows machine before final approval.
I just have two comments, both are very minor and optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! Will update NEWS.md and bump the version to 0.5.3.
Submission Checklist
Summary
This PR adds the ability to install
cmdstan
and run all models through WSL, all from a regular Windows R session.The end-user simply needs to add
wsl=TRUE
to theinstall_cmdstan()
call, and all model compilation and execution for that installation will subsequently be run through WSL. No other user-facing changes are made.In addition to the known speed differences between Stan models under Windows & WSL, this also provides an accessible means for running MPI models in Windows
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: