-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSL - Run cmdstan
and models under WSL filesystem
#696
WSL - Run cmdstan
and models under WSL filesystem
#696
Conversation
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
- Coverage 90.56% 88.44% -2.12%
==========================================
Files 12 12
Lines 3890 4017 +127
==========================================
+ Hits 3523 3553 +30
- Misses 367 464 +97
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closing to run workflows in my own fork |
Thanks Andrew! Will do another release this week, hopefully with some other minor features. |
Great! I've just got one more PR to fix the WSL CI tests hanging, will have that in a couple days |
Submission Checklist
Summary
This PR refactors the WSL functionality introduced in #677 so that
cmdstan
is built and stored within the WSL installation, and the model execution occurs exclusively within the WSL installation as well.This is possible due to functionality for accessing the WSL filesystem from Windows via the
//wsl$/
network path. This allows forcmdstanr
to execute models through WSL, and then access the generated.csv
files from the windows session. This is also reflected in the cmdstan path, for example:My anecdotal experience so far is a noticeable decrease in both
cmdstan
installation time, as well as model compilation timeCopyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: