-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pathfinder branch #727
Conversation
Add optional methods for log_prob, grad_log_prob, hessian, un/constrain pars
Add optional method for exposing stan functions to R
Make constrain_pars behaviour consistent with rstan
Allow exposing functions without sampling
Store return codes instead of always querying exit status
Update posterior vignette
enable jacobian argument for optimization
Fix init_model_methods for models with no data
Should this be closed and we can open up a new PR for pathfinder in cmdstanr? |
I think we should merge this, which would merge master into the pathfinder branch and then review, test and get it merged? |
how does the user call the Pathfinder method? @WardBrian @jgabry - the usual concern - making the interfaces line up. |
Agree with @rok-cesnovar that we should merge this (this PR doesn't merge pathfinder into master, just updates the pathfinder branch). Then we can have a discussion with CmdStanPy devs about what pathfinder should look like in CmdStanR/Py and either start a new pathfinder branch or update this one (if the design is similar enough to what's here already). That make sense to everyone? |
Will go ahead and merge this (which just updates the pathfinder branch) and we'll eventually do a new PR (like @SteveBronder mentioned) to get pathfinder into the master branch when the design is agreed upon for all the interfaces. |
Agree! I wrote it a while ago, and very quickly, so we might be able to save some things from this branch but may also just need to get rid of it. |
@jgabry wrote in #726: