Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLEVA Schema #1864

Merged
merged 229 commits into from
Sep 30, 2023
Merged

CLEVA Schema #1864

merged 229 commits into from
Sep 30, 2023

Conversation

lyy1994
Copy link
Contributor

@lyy1994 lyy1994 commented Sep 27, 2023

This PR mainly updates the corresponding entries of CLEVA in schema.yaml. It also updates the links for accessing CLEVA data, such that users do not need to download the whole dataset if they just want to run on a few CLEVA scenarios.

lyy1994 and others added 30 commits August 18, 2023 01:05
2. Use chinese_bleu_1 in Pinyin Transliteration Task
Add Pinyin Transliteration Scenario
Add Scenarios: Instruction Following, Classical Chinese Understanding, and Sentiment Analysis
2. Change disinformation to fact_check
@@ -43,7 +43,15 @@ class Description(PerturbationDescription):
name: str = "chinese_typos"

# For downloading resources
ASSET_URL = "https://drive.google.com/uc?id=1p5mldLpKxI-63H8YEruGJghtD1dZJI8k"
ASSET_URL = "http://39.108.215.175/assets/butter_finger"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it is better to have this be a domain name due to (1) HTTPS security and (2) it's easier to lose an allocated IP address than a domain name. Is there any plan to change the URL back to a HTTPS domain name?

For instance, these assets could be hosted in a GitHub repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the Great Firewall, Google Drive is not accessible in China. For this reason, and to ensure our project's long-term stability, we have rented a cloud server with a two-year contract. This means that this IP address and related service will remain stable in the foreseeable future.

In the meantime, we are applying for a domain and an SSL certificate. We estimate the process should be completed within 2 weeks. Immediately after, we will update the URLs to use the new HTTPS domain name.

Please let me know how you feel about this plan. We truly value your suggestions. Thank you!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing your plans. Sounds good to me.

src/helm/benchmark/static/schema.yaml Outdated Show resolved Hide resolved
src/helm/benchmark/static/schema.yaml Outdated Show resolved Hide resolved
src/helm/benchmark/static/schema.yaml Outdated Show resolved Hide resolved
src/helm/benchmark/static/schema.yaml Outdated Show resolved Hide resolved
src/helm/benchmark/static/schema.yaml Outdated Show resolved Hide resolved
src/helm/benchmark/static/schema.yaml Outdated Show resolved Hide resolved
src/helm/benchmark/static/schema.yaml Outdated Show resolved Hide resolved
src/helm/benchmark/static/schema.yaml Outdated Show resolved Hide resolved
src/helm/benchmark/static/schema.yaml Outdated Show resolved Hide resolved
@lyy1994 lyy1994 requested a review from yifanmai September 28, 2023 15:59
Copy link
Collaborator

@yifanmai yifanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one suggestion. We should be able to merge after fixing that.

@@ -43,7 +43,15 @@ class Description(PerturbationDescription):
name: str = "chinese_typos"

# For downloading resources
ASSET_URL = "https://drive.google.com/uc?id=1p5mldLpKxI-63H8YEruGJghtD1dZJI8k"
ASSET_URL = "http://39.108.215.175/assets/butter_finger"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing your plans. Sounds good to me.

src/helm/benchmark/static/schema.yaml Outdated Show resolved Hide resolved
@yifanmai yifanmai merged commit a94b6ff into stanford-crfm:main Sep 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants