Add mean row aggregation to HELM summarize #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farzaank
commented
Sep 24, 2024
farzaank
commented
Sep 24, 2024
yifanmai
requested changes
Sep 24, 2024
| @@ -119,6 +119,9 @@ class MetricGroup(Field): | |||
| hide_win_rates: Optional[bool] = None | |||
| """If set to true, do not compute win rates.""" | |||
|
|
|||
| aggregation_strategies: Optional[List[str]] = None | |||
There was a problem hiding this comment.
@percyliang could you review this change to the schema?
yifanmai
approved these changes
Sep 25, 2024
| if strategy == "win_rate": | ||
| WIN_RATE_AGGREGATION = "mean" | ||
| win_rates = compute_aggregate_row_win_rates(table, aggregation=WIN_RATE_AGGREGATION) | ||
| description = "How many models this model outperform on average (over columns)." |
There was a problem hiding this comment.
nit: outperform -> outperforms (fix pre-existing typo)
|
Let's merge this first and have @percyliang review post-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option for users to do mean metric aggregation as opposed to mean win rate within helm summarize.
In addition it allows for mutliple types of aggregation in parallel (as opposed to just one).