Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to win rate column if no aggregation strategies are specified #3030

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

yifanmai
Copy link
Collaborator

#2997 broke reverse compatibility by defaulting to no win-rate or mean columns, rather than defaulting to a win-rate column. This restores the original behavior by defaulting to a win-rate column.

@yifanmai yifanmai requested a review from farzaank September 26, 2024 23:26
@yifanmai yifanmai merged commit 9e9738f into main Oct 1, 2024
6 checks passed
@yifanmai yifanmai deleted the yifanmai/fix-win-rate-config branch October 1, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants