Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: e2e support all examples #1552

Merged
merged 17 commits into from
Nov 30, 2022
Merged

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Nov 23, 2022

Description

  1. move environment preparation to shell script
  2. change some process call to api call (dataset/model/runtime build, eval run, login, instance select)
  3. make client api (dataset/model/runtime build, eval run) return resource id
  4. add make prepare-data to unify all example data preparation processes
  5. remove mnist model file from code repo

verification

http://full-expl3-20221125.pre.intra.starwhale.ai/projects/3/evaluations
http://full-expl4-20221125.pre.intra.starwhale.ai/projects/3/evaluations
image
image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added the e2e label Nov 23, 2022
@anda-ren anda-ren self-assigned this Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1552 (4590c63) into main (2119afd) will increase coverage by 7.07%.
The diff coverage is 92.30%.

@@             Coverage Diff              @@
##               main    #1552      +/-   ##
============================================
+ Coverage     81.51%   88.58%   +7.07%     
============================================
  Files           330       70     -260     
  Lines         16467     8212    -8255     
  Branches        910        0     -910     
============================================
- Hits          13423     7275    -6148     
+ Misses         2670      937    -1733     
+ Partials        374        0     -374     
Flag Coverage Δ
controller ?
standalone 88.58% <92.30%> (+<0.01%) ⬆️
unittests 88.58% <92.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/eval/view.py 70.22% <50.00%> (-0.19%) ⬇️
client/starwhale/api/_impl/job.py 99.14% <100.00%> (+0.03%) ⬆️
client/starwhale/base/view.py 83.50% <100.00%> (ø)
client/starwhale/core/dataset/model.py 78.30% <100.00%> (+0.10%) ⬆️
client/starwhale/core/dataset/view.py 61.11% <100.00%> (+0.27%) ⬆️
client/starwhale/core/model/model.py 84.70% <100.00%> (+0.06%) ⬆️
client/starwhale/core/model/view.py 69.07% <100.00%> (+0.32%) ⬆️
client/starwhale/core/runtime/model.py 94.81% <100.00%> (+<0.01%) ⬆️
client/starwhale/core/runtime/view.py 92.00% <100.00%> (+0.06%) ⬆️
.../task/status/watchers/TaskWatcherForJobStatus.java
... and 259 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anda-ren anda-ren changed the title WIP: ci: e2e support all examples ci: e2e support all examples Nov 25, 2022
@anda-ren anda-ren marked this pull request as ready for review November 25, 2022 11:03
client/starwhale/api/_impl/job.py Outdated Show resolved Hide resolved
example/runtime/pytorch-e2e/requirements-sw-lock.txt Outdated Show resolved Hide resolved
client/starwhale/api/_impl/job.py Show resolved Hide resolved
client/starwhale/base/view.py Show resolved Hide resolved
client/starwhale/core/dataset/cli.py Outdated Show resolved Hide resolved
client/starwhale/core/dataset/cli.py Outdated Show resolved Hide resolved
@tianweidut tianweidut self-requested a review November 25, 2022 11:26
@anda-ren
Copy link
Member Author

validation after review changes:
http://full-expl-20221128.pre.intra.starwhale.ai/projects/3/evaluations

@anda-ren anda-ren added this to the v0.3.3 milestone Nov 29, 2022
@anda-ren
Copy link
Member Author

@tianweidut tianweidut self-requested a review November 30, 2022 01:51
@tianweidut
Copy link
Member

Others LGTM

@tianweidut tianweidut self-requested a review November 30, 2022 10:25
@tianweidut tianweidut merged commit 607670b into star-whale:main Nov 30, 2022
@anda-ren anda-ren deleted the e2e_add_example branch December 2, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants