Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): disable useless git lfs config #1582

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

tianweidut
Copy link
Member

Description

  • related pr: ci: e2e support all examples #1552
  • mnist/models/mnist.pth file has already been removed, so the client e2e test can disable git lfs to reduce github's network brandwith.

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added the chore 🛎️ some tiny change label Dec 5, 2022
@tianweidut tianweidut added this to the v0.3.4 milestone Dec 5, 2022
@tianweidut tianweidut self-assigned this Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1582 (a92093d) into main (8983a8c) will increase coverage by 7.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1582      +/-   ##
============================================
+ Coverage     82.70%   89.75%   +7.05%     
============================================
  Files           333       73     -260     
  Lines         17162     8864    -8298     
  Branches        917        0     -917     
============================================
- Hits          14194     7956    -6238     
+ Misses         2580      908    -1672     
+ Partials        388        0     -388     
Flag Coverage Δ
controller ?
standalone 89.75% <ø> (ø)
unittests 89.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...whale/mlops/domain/job/status/JobUpdateHelper.java
.../ai/starwhale/mlops/domain/model/ModelService.java
...ale/mlops/domain/job/converter/JobBoConverter.java
...guration/security/JwtAuthenticationEntryPoint.java
...tarwhale/mlops/datastore/impl/MemoryTableImpl.java
...tarwhale/mlops/api/protocol/model/ModelInfoVo.java
...va/ai/starwhale/mlops/domain/bundle/BundleUrl.java
...arwhale/mlops/datastore/parquet/SwReadSupport.java
...whale/mlops/domain/panel/po/PanelPluginEntity.java
.../java/ai/starwhale/mlops/api/SystemController.java
... and 250 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit dee9dd5 into star-whale:main Dec 5, 2022
@tianweidut tianweidut deleted the chore/disable-useless-lfs branch April 14, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants