Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add import and export for ft eval #3002

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Nov 21, 2023

Description

  1. update model info for eval when release ft model
  2. add import and export for ft eval, releated feat(datastore): add table migration #3003
  3. fix create ft-eval error

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (857cff0) 82.51% compared to head (8a38e0e) 73.33%.
Report is 2 commits behind head on main.

❗ Current head 8a38e0e differs from pull request most recent head 21f5060. Consider uploading reports for the commit 21f5060 to get more accurate results

Files Patch % Lines
...ava/ai/starwhale/mlops/api/FineTuneController.java 0.00% 4 Missing ⚠️
...ain/java/ai/starwhale/mlops/domain/job/JobDao.java 0.00% 3 Missing ⚠️
...ain/java/ai/starwhale/mlops/api/JobController.java 0.00% 1 Missing and 1 partial ⚠️
.../starwhale/mlops/domain/ft/FineTuneAppService.java 85.71% 1 Missing and 1 partial ⚠️
...lops/domain/evaluation/storage/EvaluationRepo.java 96.29% 1 Missing ⚠️
...ops/domain/ft/FineTuneEvaluationUpdateWatcher.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3002      +/-   ##
============================================
- Coverage     82.51%   73.33%   -9.19%     
- Complexity     3125     3131       +6     
============================================
  Files           563      436     -127     
  Lines         30404    15266   -15138     
  Branches       1833     1774      -59     
============================================
- Hits          25088    11195   -13893     
+ Misses         4501     3257    -1244     
+ Partials        815      814       -1     
Flag Coverage Δ
console ?
controller 73.33% <75.47%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goldenxinxing goldenxinxing changed the title fix(controller): update model info for eval when release ft model fix(controller): add import and export for ft eval Nov 21, 2023
@goldenxinxing goldenxinxing changed the title fix(controller): add import and export for ft eval feat(controller): add import and export for ft eval Nov 21, 2023
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 34d2018 into star-whale:main Nov 22, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e feature ✨ new feature hotfix 🔥 hotfix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants