Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datastore): add table migration #3003

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Nov 21, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the feature ✨ new feature label Nov 21, 2023
@goldenxinxing goldenxinxing self-assigned this Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (2e624a3) 82.52% compared to head (dd6836b) 73.30%.

Files Patch % Lines
...n/java/ai/starwhale/mlops/datastore/DataStore.java 71.79% 4 Missing and 7 partials ⚠️
...tarwhale/mlops/datastore/impl/MemoryTableImpl.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3003      +/-   ##
============================================
- Coverage     82.52%   73.30%   -9.23%     
- Complexity     3119     3124       +5     
============================================
  Files           563      436     -127     
  Lines         30365    15227   -15138     
  Branches       1826     1772      -54     
============================================
- Hits          25060    11162   -13898     
+ Misses         4495     3251    -1244     
- Partials        810      814       +4     
Flag Coverage Δ
console ?
controller 73.30% <72.72%> (+<0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 60500c8 into star-whale:main Nov 21, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants