Create collection mixed casing fix #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/stargate/data-api into create-collection-mixed-casing-fix
|
LGTM |
Yuqi-Du
approved these changes
May 28, 2024
amorton
requested changes
May 28, 2024
...in/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/CreateCollectionOperation.java
Show resolved
Hide resolved
| if (!indexingDenyAll()) { | ||
| String existKeys = | ||
| "CREATE CUSTOM INDEX IF NOT EXISTS %s_exists_keys ON \"%s\".\"%s\" (exist_keys) USING 'StorageAttachedIndex'"; | ||
| apprender |
There was a problem hiding this comment.
Add a comment to explain why we are using quoted identifiers, comments like this make it less likely another person will change it later.
I would also consider a helper function or lambda to quote the identifier rather than have lots of \" in a string which can easily become unbalanced.
Comment also for the create table statement.
Example "Using CQL quoted identifiers to preserve the case of the identifiers in the CQL schema, and enforce case sensitive comparisons. This is expected behaviour for the Data API."
amorton
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Create collection mixed casing fix
Which issue(s) this PR fixes:
Fixes #1110
Checklist