Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sort option for deleteOne and updateOne command #399

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Added sort option for deleteOne and updateOne command #399

merged 3 commits into from
Apr 26, 2023

Conversation

maheshrajamani
Copy link
Contributor

@maheshrajamani maheshrajamani commented Apr 26, 2023 •
edited
Loading

What this PR does:
Added sort option for deleteOne and updateOne command
Which issue(s) this PR fixes:
Fixes #396

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@maheshrajamani maheshrajamani marked this pull request as ready for review April 26, 2023 13:58
@maheshrajamani maheshrajamani requested a review from a team as a code owner April 26, 2023 13:58
vkarpov15
vkarpov15 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@maheshrajamani
Copy link
Contributor Author

LGTM 👍

Just added updateOne changes to the same PR.

@maheshrajamani maheshrajamani changed the title Added sort option for DeleteOneCommand Added sort option for deleteOne and updateOne command Apr 26, 2023
tatu-at-datastax
tatu-at-datastax approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maheshrajamani maheshrajamani merged commit b85bb4a into main Apr 26, 2023
@maheshrajamani maheshrajamani deleted the sort-pr-396 branch April 26, 2023 17:39
@vkarpov15 vkarpov15 mentioned this pull request May 1, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support deleteOne() and updateOne() with sort
3 participants
@maheshrajamani @vkarpov15 @tatu-at-datastax