Support sort with deleteOne, docs -> document/documents #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vkarpov15 Good improvements! |
|
Correct, this will only work on latest JSON API. I'll fix the merge conflicts later today. |
|
@vkarpov15 I resolved the merge conflicts, updated the API version and also changed the JSON API port as required with the latest version (port has been changed from 8080 to 8181) |
|
LGTM, thanks @kathirsvn |
1 similar comment
|
LGTM, thanks @kathirsvn |
kathirsvn
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Various fixes for new jsonapi changes, taking into account stargate/data-api#399, stargate/data-api#141 + stargate/data-api#402.
Also sundry other improvements:
_.keys()->Object.keys(). No need to use_.keys(),Object.keys()is sufficiently well supported.StargateMongoose - [object Object] ConnectionTEST_DOC_DBis set to a valid value.Which issue(s) this PR fixes:
Fixes #
Checklist