Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Merge main contract segmentation into main #1331

Merged
merged 8 commits into from
Jan 14, 2024

Conversation

liorgold2
Copy link
Contributor

@liorgold2 liorgold2 commented Jan 13, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (a7be26c) 70.92% compared to head (5e429f2) 70.35%.
Report is 10 commits behind head on main.

Files Patch % Lines
crates/blockifier/src/execution/contract_class.rs 0.00% 50 Missing ⚠️
crates/blockifier/src/state/cached_state.rs 57.69% 11 Missing ⚠️
crates/native_blockifier/src/lib.rs 0.00% 8 Missing ⚠️
.../blockifier/src/execution/entry_point_execution.rs 83.33% 3 Missing and 4 partials ⚠️
...ates/native_blockifier/src/transaction_executor.rs 64.28% 3 Missing and 2 partials ⚠️
crates/blockifier/src/execution/entry_point.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
- Coverage   70.92%   70.35%   -0.58%     
==========================================
  Files          59       59              
  Lines        7346     7484     +138     
  Branches     7346     7484     +138     
==========================================
+ Hits         5210     5265      +55     
- Misses       1722     1799      +77     
- Partials      414      420       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1, 5 of 9 files at r5, 4 of 4 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @elintul)

Copy link
Contributor Author

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)

a discussion (no related file):
Merge instead of squash


Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 7 files at r1, 5 of 9 files at r5, 4 of 4 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)

a discussion (no related file):

Previously, liorgold2 wrote…

Merge instead of squash

Please open a Python PR with the commit hash of your branch and wait for its CI to pass before this is merged.


Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)

Copy link
Contributor Author

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)

a discussion (no related file):

Previously, elintul (Elin) wrote…

Please open a Python PR with the commit hash of your branch and wait for its CI to pass before this is merged.

It'll be https://reviewable.io/reviews/starkware-industries/starkware/33401#- once it passes Hodor.


Copy link
Contributor Author

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)

a discussion (no related file):

Previously, liorgold2 wrote…

It'll be https://reviewable.io/reviews/starkware-industries/starkware/33401#- once it passes Hodor.

Actually, https://reviewable.io/reviews/starkware-industries/starkware/33398#-. The other one is not ready yet.


Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)

@liorgold2 liorgold2 merged commit 8f249b5 into main Jan 14, 2024
11 checks passed
@liorgold2 liorgold2 deleted the lior/merge-main-contract-segmentation-into-main branch January 14, 2024 13:15
gswirski pushed a commit to reilabs/blockifier that referenced this pull request Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants