-
Notifications
You must be signed in to change notification settings - Fork 107
Merge main contract segmentation into main #1331
Merge main contract segmentation into main #1331
Conversation
Collect the set of visited PCs in the block.
…n-contract-segmentation Merge main into main contract segmentation
…n-contract-segmentation Merge main into main contract segmentation
… HEAD (no conflicts).
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1331 +/- ##
==========================================
- Coverage 70.92% 70.35% -0.58%
==========================================
Files 59 59
Lines 7346 7484 +138
Branches 7346 7484 +138
==========================================
+ Hits 5210 5265 +55
- Misses 1722 1799 +77
- Partials 414 420 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r1, 5 of 9 files at r5, 4 of 4 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)
a discussion (no related file):
Merge instead of squash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r1, 5 of 9 files at r5, 4 of 4 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)
a discussion (no related file):
Previously, liorgold2 wrote…
Merge instead of squash
Please open a Python PR with the commit hash of your branch and wait for its CI to pass before this is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)
a discussion (no related file):
Previously, elintul (Elin) wrote…
Please open a Python PR with the commit hash of your branch and wait for its CI to pass before this is merged.
It'll be https://reviewable.io/reviews/starkware-industries/starkware/33401#- once it passes Hodor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)
a discussion (no related file):
Previously, liorgold2 wrote…
It'll be https://reviewable.io/reviews/starkware-industries/starkware/33401#- once it passes Hodor.
Actually, https://reviewable.io/reviews/starkware-industries/starkware/33398#-. The other one is not ready yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)
This change is