This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
fix: remove unnecessary re-computation of total gas field #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1971 +/- ##
==========================================
+ Coverage 78.17% 78.18% +0.01%
==========================================
Files 62 62
Lines 8842 8839 -3
Branches 8842 8839 -3
==========================================
- Hits 6912 6911 -1
Misses 1492 1492
+ Partials 438 436 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
python - https://github.com/starkware-industries/starkware/pull/35181
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
dorimedini-starkware
previously approved these changes
Jun 9, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
crates/blockifier/src/transaction/transaction_execution.rs line 124 at r1 (raw file):
resources: actual_resources, gas: total_gas, ..
are there more than these 4 fields in TransactionReceipt? if not, delete the .. (wonder why clippy didn't block you...?)
Code quote:
..
AvivYossef-starkware
force-pushed
the
aviv/fix_total_gas
branch
from
66882a7
to
42cb530
Compare
AvivYossef-starkware
force-pushed
the
aviv/fix_total_gas
branch
from
42cb530
to
aebe815
Compare
dorimedini-starkware
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
* Use name hash for model identifiers * Dojo layout rework * support nested tuple/array/bytearray * new Layout::Enum to support enum with different variant data * merge from storage-layout branch * cleaning * support direct array/span introspect instead of generating it during code compilation * fix Copy trait implementation for Array<u64> * generate the model/field selector value instead of selector!(...) * feat: start implementing new layout on torii wip * update: cainome for serde & serialize layout * feat: handle bytearray in ty * feat: add new layout types (tuple/array/bytearray) to types & grpc * fix: gql * fix: model id for processors * featr: start handling sql new tytpes * feat: make tuple and bytearray work * feat: store set record for tuples * feat: start working on array * feat: set support for bytearray & tuples * feat: primitive arrays working * feat: complex array types * feat: start work on graphql for arrays * fix: tuples for graphql * fix: sanitize member type names gql * feat: remove tuple from scalar types * chore: fetch row by idx * feat: add new type data for array * feat: add updated_at for entity models data * feat: start handle array type datalogic * refactor: use list typedata * refactor: modela data recursive * feat: get list with new type data correctly * feat: finished array support with nested types ✨ * fix: schema * feat: torii packing * integrates scarb nightly (starkware-libs#1971) wip with scarb nightly * fix: fmt + regenerate world bindings * fix: remove serialization workaround * fix: remove cairo warnings for build * Storage layout improvement (starkware-libs#1965) * Finalize the storage layout rework - As the type recursion issue was fixed by Starkware, Layout/FieldLayout can be simplified. - Update introspect size() and ty() methods - Remove old model layout parsing in model.rs - Split and reorganize introspect.rs code * fix fmt+clippy * update ABI binding * fix cairo fmt * feat: new parse schema function using cainome for model * feat: complex enum supported ✨ * chore: bump blockifier and patch deps to use scarb nightly * fix: run CAIRO_FIX tests and rebuild artifacts * fix: use Tricks for dojo language server * fix: remove async for language server * wip: fix tests * feat: add union type data for enums * feat: continue work on type unions for enums * feat: refactor complex enums * feat: completely switch to using nested types for enums * fmt * clippy * chore * Automatically add Introspect derive attribute for Dojo models (starkware-libs#1982) * Automatically add Introspect derive attribute for Dojo models * fix fmt+clippy * fix warning about trait path in Impl * update dojo-lang tests * fix dojo-lang system * fix dojo-world model test * fix option<T> introspect * fix: ensure all models are correctly derived --------- Co-authored-by: glihm <dev@glihm.net> * fix: adjust tests with missing model * wip: auth tests debug * fix: ensure auth is using selector * fix: fix some tests * fix: models tests enum * fix: other tests * chore: tuple for u256 * refactor: u256 struct * feat: simple enum types non nested + fix texts * fmt * fix: filtering by enum type name * chore: clippy * fmt * fix: sql test * refactor: packed size in tests & simply functions * fix: switch back u256 to primitive * feat: use correct primitive u256 type & filtering * wip * chore: subscription test * migration clippy * wip * feat: add new example with more types * fix: strip enum variant type inf * fix: nested tuples * chore * chore: remove debug logs * fix: fix tests with new model * fix: add missing manifests * fix: fix cairo fmt * fix: arrays * fix: add tests and enhance error messages * fix: fix build test and disable typescript for now * fix: avoid race on manifest file for sql test * feat: refactor schema deser from db & handle nested arrays * chore: delete array elements on update * fmt * feat: add sozo prefix parsing for calldata * fix: ensure migration for sql test waits for transactions * fix: ensure build test works on a copy project * fix: add missing transaction wait * temp-fix: arrays --------- Co-authored-by: Tarrence van As <tarrence@vanas.family> Co-authored-by: remy.baranx@gmail.com <remy.baranx@gmail.com> Co-authored-by: glihm <dev@glihm.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is