Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

fix(concurrency): fix the tx_index offset in validate_reads and apply… #1982

Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix(concurrency): fix the tx_index offset in validate_reads and apply… #1982

merged 1 commit into from
Jun 16, 2024

Conversation

OriStarkware
Copy link
Contributor

@OriStarkware OriStarkware commented Jun 13, 2024 •
edited by alon-dotan-starkware
Loading

…_writes

This change is Reviewable

@OriStarkware OriStarkware self-assigned this Jun 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.37%. Comparing base (4505d16) to head (d1cadaf).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1982      +/-   ##
==========================================
- Coverage   78.38%   78.37%   -0.01%     
==========================================
  Files          62       62              
  Lines        8855     8856       +1     
  Branches     8855     8856       +1     
==========================================
  Hits         6941     6941              
- Misses       1475     1476       +1     
  Partials      439      439

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OriStarkware OriStarkware force-pushed the ori/starknet/concurrency/deployed_contracts/versioned_state/fix_plus_1 branch from 758e4f4 to d1cadaf Compare June 13, 2024 13:59
Yoni-Starkware
Yoni-Starkware approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware and @noaov1)

barak-b-starkware
barak-b-starkware approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@barak-b-starkware barak-b-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@OriStarkware OriStarkware merged commit 42ea6e3 into main Jun 16, 2024
8 of 9 checks passed
@OriStarkware OriStarkware deleted the ori/starknet/concurrency/deployed_contracts/versioned_state/fix_plus_1 branch June 16, 2024 09:50
gswirski pushed a commit to reilabs/blockifier that referenced this pull request Jun 26, 2024
@Larkooo @tarrencev
@remybar @glihm
feat: new layout support (starkware-libs#1970)
e614651 
* Use name hash for model identifiers

* Dojo layout rework

* support nested tuple/array/bytearray

* new Layout::Enum to support enum with different variant data

* merge from storage-layout branch

* cleaning

* support direct array/span introspect instead of generating it during code compilation

* fix Copy trait implementation for Array<u64>

* generate the model/field selector value instead of selector!(...)

* feat: start implementing new layout on torii wip

* update: cainome for serde & serialize layout

* feat: handle bytearray in ty

* feat: add new layout types (tuple/array/bytearray) to types & grpc

* fix: gql

* fix: model id for processors

* featr: start handling sql new tytpes

* feat: make tuple and bytearray work

* feat: store set record for tuples

* feat: start working on array

* feat: set support for bytearray & tuples

* feat: primitive arrays working

* feat: complex array types

* feat: start work on graphql for arrays

* fix: tuples for graphql

* fix: sanitize member type names gql

* feat: remove tuple from scalar types

* chore: fetch row by idx

* feat: add new type data for array

* feat: add updated_at for entity models data

* feat: start handle array type datalogic

* refactor: use list typedata

* refactor: modela data recursive

* feat: get list with new type data correctly

* feat: finished array support with nested types ✨

* fix: schema

* feat: torii packing

* integrates scarb nightly (starkware-libs#1971)

wip with scarb nightly

* fix: fmt + regenerate world bindings

* fix: remove serialization workaround

* fix: remove cairo warnings for build

* Storage layout improvement (starkware-libs#1965)

* Finalize the storage layout rework

- As the type recursion issue was fixed by Starkware, Layout/FieldLayout
  can be simplified.
- Update introspect size() and ty() methods
- Remove old model layout parsing in model.rs
- Split and reorganize introspect.rs code

* fix fmt+clippy

* update ABI binding

* fix cairo fmt

* feat: new parse schema function using cainome for model

* feat: complex enum supported ✨

* chore: bump blockifier and patch deps to use scarb nightly

* fix: run CAIRO_FIX tests and rebuild artifacts

* fix: use Tricks for dojo language server

* fix: remove async for language server

* wip: fix tests

* feat: add union type data for enums

* feat: continue work on type unions for enums

* feat: refactor complex enums

* feat: completely switch to using nested types for enums

* fmt

* clippy

* chore

* Automatically add Introspect derive attribute for Dojo models (starkware-libs#1982)

* Automatically add Introspect derive attribute for Dojo models

* fix fmt+clippy

* fix warning about trait path in Impl

* update dojo-lang tests

* fix dojo-lang system

* fix dojo-world model test

* fix option<T> introspect

* fix: ensure all models are correctly derived

---------

Co-authored-by: glihm <dev@glihm.net>

* fix: adjust tests with missing model

* wip: auth tests debug

* fix: ensure auth is using selector

* fix: fix some tests

* fix: models tests enum

* fix: other tests

* chore: tuple for u256

* refactor: u256 struct

* feat: simple enum types non nested + fix texts

* fmt

* fix: filtering by enum type name

* chore: clippy

* fmt

* fix: sql test

* refactor: packed size in tests &  simply functions

* fix: switch back u256 to primitive

* feat: use correct primitive u256 type & filtering

* wip

* chore: subscription test

* migration clippy

* wip

* feat: add new example with more types

* fix: strip enum variant type inf

* fix: nested tuples

* chore

* chore: remove debug logs

* fix: fix tests with new model

* fix: add missing manifests

* fix: fix cairo fmt

* fix: arrays

* fix: add tests and enhance error messages

* fix: fix build test and disable typescript for now

* fix: avoid race on manifest file for sql test

* feat: refactor schema deser from db & handle nested arrays

* chore: delete array elements on update

* fmt

* feat: add sozo prefix parsing for calldata

* fix: ensure migration for sql test waits for transactions

* fix: ensure build test works on a copy project

* fix: add missing transaction wait

* temp-fix: arrays

---------

Co-authored-by: Tarrence van As <tarrence@vanas.family>
Co-authored-by: remy.baranx@gmail.com <remy.baranx@gmail.com>
Co-authored-by: glihm <dev@glihm.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

@barak-b-starkware barak-b-starkware barak-b-starkware approved these changes

@noaov1 noaov1 Awaiting requested review from noaov1

Assignees

@OriStarkware OriStarkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OriStarkware @codecov-commenter @Yoni-Starkware @barak-b-starkware