fix: balance print in errors

[AvivYossef-starkware]

This change is 

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.61%. Comparing base (b898b1c) to head (c3e874e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1986   +/-   ##
=======================================
  Coverage   78.60%   78.61%           
=======================================
  Files          62       62           
  Lines        8892     8895    +3     
  Branches     8892     8895    +3     
=======================================
+ Hits         6990     6993    +3     
  Misses       1455     1455           
  Partials      447      447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)

---

crates/blockifier/src/transaction/errors.rs line 36 at r1 (raw file):

    },
    #[error("Max fee ({}) exceeds balance ({}).", max_fee.0, balance_to_big_uint(balance_low, balance_high))]
    MaxFeeExceedsBalance { max_fee: Fee, balance_low: StarkFelt, balance_high: StarkFelt },

in both of these error variants: change the balance from two fields to a single BigUint field and create a BigUint when the error is created, no reason to do logic here

Suggestion:

    #[error(
        "L1 gas bounds (max amount: {max_amount}, max price: {max_price}) exceed balance ({}).",
        balance_to_big_uint(balance_low, balance_high)
    )]
    L1GasBoundsExceedBalance {
        max_amount: u64,
        max_price: u128,
        balance: BigUint,
    },
    #[error("Max fee ({}) exceeds balance ({}).", max_fee.0, balance_to_big_uint(balance_low, balance_high))]
    MaxFeeExceedsBalance { max_fee: Fee, balance: BigUint },

---

crates/blockifier/src/transaction/transactions_test.rs line 2021 at r1 (raw file):

    let int = balance_to_big_uint(&StarkFelt::from(16_u64), &StarkFelt::from(1_u64));
    // 340282366920938463463374607431768211472 = 1 << 128 + 16
    assert!(format!("{}", int) == "340282366920938463463374607431768211472");

better IMO

Suggestion:

    assert!(format!("{}", int) == (uint!(u128::MAX) + 17).to_string());

[AvivYossef-starkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/blockifier/src/transaction/errors.rs line 36 at r1 (raw file):

Previously, dorimedini-starkware wrote…

in both of these error variants: change the balance from two fields to a single BigUint field and create a BigUint when the error is created, no reason to do logic here

Done.

---

crates/blockifier/src/transaction/transactions_test.rs line 2021 at r1 (raw file):

Previously, dorimedini-starkware wrote…

better IMO

Done.

[dorimedini-starkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

---

crates/blockifier/src/transaction/transactions_test.rs line 2022 at r2 (raw file):

    let int = balance_to_big_uint(&StarkFelt::from(16_u64), &StarkFelt::from(1_u64));
    assert!(
        format!("{}", int) == format!("{}", (BigUint::from(u128::MAX) + BigUint::from(17_u128)))

Suggestion:

(BigUint::from(u128::MAX) + BigUint::from(17_u128)).to_string()

[AvivYossef-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/src/transaction/transactions_test.rs line 2022 at r2 (raw file):

    let int = balance_to_big_uint(&StarkFelt::from(16_u64), &StarkFelt::from(1_u64));
    assert!(
        format!("{}", int) == format!("{}", (BigUint::from(u128::MAX) + BigUint::from(17_u128)))

Done.

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)