Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Merge main-v0.13.2 into main #2098

Merged
merged 12 commits into from
Jul 18, 2024
Merged

Conversation

barak-b-starkware
Copy link
Collaborator

@barak-b-starkware barak-b-starkware commented Jul 18, 2024

This change is Reviewable

@barak-b-starkware
Copy link
Collaborator Author

Src Dst crates/blockifier/src/test_utils.rs

Copy link
Collaborator Author

@barak-b-starkware barak-b-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware)

@barak-b-starkware
Copy link
Collaborator Author

crates/blockifier/src/test_utils.rs line 52 at r2 (raw file):

// TODO(Aviv, 14/7/2024): Move from test utils module, and use it in ContractClassVersionMismatch
// error.
#[derive(Clone, Hash, PartialEq, Eq, Copy, Debug)]

@giladchase
@AvivYossef-starkware
Please approve

Code quote:

// TODO(Aviv, 14/7/2024): Move from test utils module, and use it in ContractClassVersionMismatch
// error.
#[derive(Clone, Hash, PartialEq, Eq, Copy, Debug)]

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 20 of 20 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @giladchase, and @noaov1)

@barak-b-starkware barak-b-starkware merged commit 69e94ce into main Jul 18, 2024
11 checks passed
@barak-b-starkware barak-b-starkware deleted the barak/merge-main-v0.13.2-into-main branch July 18, 2024 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants