Made bounded-int div_rem rhs - non-zero.

[orizi]

Stack:

• Added implementation for divmod for signed ints. #5716
• Added support for Nz-mul-Nz remaining Nz. #5715
• Updated bounded_int_constrain to allow constraining NonZero of ranges. #5714
• Made bounded-int div_rem rhs - non-zero. #5713 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-sierra/src/extensions/modules/bounded_int.rs line 168 at r1 (raw file):

        // Supporting only division of a non-negative number by a positive number.
        // TODO(orizi): Consider relaxing the constraint, and defining the div_rem of negatives.
        if lhs_range.lower.is_negative() || !rhs_range.lower.is_positive() {

why did you change it?

Code quote:

| !rhs_range.lower.is_positive()

[ilyalesokhin-starkware]

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @orizi)

[orizi]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-sierra/src/extensions/modules/bounded_int.rs line 168 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

why did you change it?

because the range now may include 0 - it just also must be NonZero.

[ilyalesokhin-starkware]

crates/cairo-lang-sierra/src/extensions/modules/bounded_int.rs line 167 at r2 (raw file):

        let rhs_range = Range::from_type(context, rhs.clone())?;
        // Supporting only division of a non-negative number by a positive number (non zero + and
        // non negative).

• or and

Suggestion:

        // Supporting only division of a non-negative number by a positive number (non zero and
        // non negative).

[ilyalesokhin-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

[ilyalesokhin-starkware]

Reviewed all commit messages.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @orizi)

[ilyalesokhin-starkware]

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @orizi)