Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added *Assign ops and Depracated *Eq ops. #5679

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented May 29, 2024

@orizi orizi mentioned this pull request May 29, 2024
@orizi orizi linked an issue May 29, 2024 that may be closed by this pull request
@orizi orizi requested a review from gilbens-starkware May 29, 2024 14:00
@orizi orizi force-pushed the pr/orizi/misc/2f5d0193 branch 2 times, most recently from ef9ed72 to 49a7db0 Compare May 29, 2024 16:31
@orizi orizi force-pushed the pr/orizi/misc/f3de9727 branch from 25be00b to 0062671 Compare May 29, 2024 16:31
@orizi orizi force-pushed the pr/orizi/misc/f3de9727 branch from 0062671 to 66ea8fd Compare May 29, 2024 17:00
@orizi orizi force-pushed the pr/orizi/misc/2f5d0193 branch from 49a7db0 to 97e4ee1 Compare May 29, 2024 17:00
@orizi orizi changed the base branch from pr/orizi/misc/f3de9727 to main May 30, 2024 07:16
@orizi orizi force-pushed the pr/orizi/misc/2f5d0193 branch from 97e4ee1 to 7584714 Compare May 30, 2024 07:17
@orizi orizi changed the base branch from main to pr/orizi/misc/f3de9727 May 30, 2024 07:17
@orizi orizi force-pushed the pr/orizi/misc/f3de9727 branch from 06e3ecf to c295e8d Compare May 30, 2024 07:42
@orizi orizi force-pushed the pr/orizi/misc/2f5d0193 branch from 7584714 to b1b4e11 Compare May 30, 2024 07:42
@orizi orizi force-pushed the pr/orizi/misc/f3de9727 branch from c295e8d to df2ec88 Compare May 30, 2024 11:38
@orizi orizi force-pushed the pr/orizi/misc/2f5d0193 branch from b1b4e11 to df418b0 Compare May 30, 2024 11:38
@orizi orizi changed the base branch from pr/orizi/misc/f3de9727 to main June 2, 2024 09:00
@orizi orizi force-pushed the pr/orizi/misc/2f5d0193 branch from df418b0 to 4f43e9b Compare June 2, 2024 09:00
@orizi orizi changed the base branch from main to pr/orizi/misc/f3de9727 June 2, 2024 09:00
@orizi orizi force-pushed the pr/orizi/misc/2f5d0193 branch from 4f43e9b to 798d5cd Compare June 3, 2024 08:13
@orizi orizi force-pushed the pr/orizi/misc/f3de9727 branch 2 times, most recently from e714019 to f07f5dc Compare June 3, 2024 08:16
@orizi orizi force-pushed the pr/orizi/misc/2f5d0193 branch from 798d5cd to 3cf96da Compare June 3, 2024 08:16
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 12 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 10 of 12 files reviewed, 2 unresolved discussions (waiting on @orizi)


corelib/src/byte_array.cairo line 352 at r2 (raw file):

}
#[feature("deprecated-op-assign-traits")]
impl ByteArrayAddEq of core::traits::AddEq<ByteArray> {

For consistency.

Suggestion:

mpl ByteArrayAddEq of AddEq<ByteArray> {

corelib/src/ops.cairo line 4 at r2 (raw file):

pub use index::{Index, IndexView};

mod arith;

It's not the Rust equivalent name right? Consider opening it to discussion.

Code quote:

mod arith;

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 10 of 12 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)


corelib/src/ops.cairo line 4 at r2 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

It's not the Rust equivalent name right? Consider opening it to discussion.

Exact same as rust, and more importantly, not pub

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 10 of 12 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)


corelib/src/byte_array.cairo line 352 at r2 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

For consistency.

don't think it is required - as it should be removed from the prelude as well.
(this will just be added to be removed)

@orizi orizi changed the base branch from pr/orizi/misc/f3de9727 to main June 4, 2024 10:26
@orizi orizi force-pushed the pr/orizi/misc/2f5d0193 branch from 3cf96da to 293c82e Compare June 4, 2024 10:26
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 12 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)

@orizi orizi added this pull request to the merge queue Jun 4, 2024
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 12 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)


corelib/src/byte_array.cairo line 352 at r2 (raw file):

Previously, orizi wrote…

don't think it is required - as it should be removed from the prelude as well.
(this will just be added to be removed)

You didn't add the path in all other places, but not really important.

Merged via the queue into main with commit 4f6663c Jun 4, 2024
86 checks passed
@orizi orizi deleted the pr/orizi/misc/2f5d0193 branch June 10, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: rename AddEq to AddAssign and so on
3 participants