Handling impl-types in destructuring as well. #5683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2024
Merged
orizi
force-pushed
the
pr/orizi/misc/2f5d0193
branch
from
49a7db0 to
97e4ee1
Compare
orizi
force-pushed
the
pr/orizi/misc/9452b708
branch
2 times, most recently
from
10b61e6 to
7134705
Compare
TomerStarkware
approved these changes
May 30, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
Closes #5680 commit-id:9452b708
orizi
force-pushed
the
pr/orizi/misc/9452b708
branch
from
7134705 to
86b930a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5680
Stack:
FieldElementusages. #5690*Assignops and Depracated*Eqops. #5679This change is