-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed FieldElement
usages.
#5690
Conversation
2b583e6
to
072f163
Compare
7584714
to
b1b4e11
Compare
how do you know the scalar is not zero? Code quote: NonZeroFelt::from_felt_unchecked(scalar) |
Do we have a regression test for that? are you sure it is the same as what we had before? Code quote: Felt252::from_bytes_be_slice(b"COMPILED_CLASS_V1"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-runner/src/casm_run/mod.rs
line 1796 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
how do you know the scalar is not zero?
Yes
crates/cairo-lang-starknet-classes/src/casm_contract_class.rs
line 135 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
Do we have a regression test for that?
are you sure it is the same as what we had before?
the casm-class hashes did not change.
072f163
to
b683ea2
Compare
b1b4e11
to
df418b0
Compare
Previously, orizi wrote…
How? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
crates/cairo-lang-runner/src/casm_run/mod.rs
line 1796 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
How?
The hint is called only for non zero scalars.
(It is always a const on the call site of the hint)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
commit-id:eee3e66d
b683ea2
to
c22e7c5
Compare
commit-id:eee3e66d
Stack:
FieldElement
usages. #5690 ⬅*Assign
ops and Depracated*Eq
ops. #5679This change is