Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar and Style Improvements #6747

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Grammar and Style Improvements #6747

merged 2 commits into from
Nov 26, 2024

Conversation

Madmaxs2
Copy link
Contributor

  1. crates/cairo-lang-language-server/CONTRIBUTING.md
  • CairoLS will print the path to this trace file and instructions how to analyze it
  • CairoLS will print the path to this trace file and instructions on how to analyze it
  • Not only this will make your development cycle faster
  • Not only will this make your development cycle faster
    Reason: Added missing preposition "on" for correct English grammar. Restructured the sentence for proper conditional clause formation.
  1. docs/FEATURE_PARITY.md
  • In this page we track the missing features
  • On this page we track the missing features
  • | deploy | ✅ | (duplicate entry removed)
    Reason: "On this page" is the correct prepositional phrase in English when referring to page content. Removed duplicate "deploy" entry to eliminate redundancy in the system calls table.

@reviewable-StarkWare
Copy link

This change is Reviewable

@piotmag769 piotmag769 removed their request for review November 26, 2024 17:39
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, @integraledelebesgue, and @mkaput)

@orizi orizi enabled auto-merge November 26, 2024 18:05
@orizi orizi added this pull request to the merge queue Nov 26, 2024
Merged via the queue into starkware-libs:main with commit cf42e47 Nov 26, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants