Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar and Style Improvements #6747

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Grammar and Style Improvements #6747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b360869
Update CONTRIBUTING.md
Madmaxs2 Nov 26, 2024
a64199f
Update FEATURE_PARITY.md
Madmaxs2 Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/cairo-lang-language-server/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ To generate a profile file, paste the following into your `.vscode/settings.json
```

This will generate a trace file that you'll be able to further analyze.
CairoLS will print the path to this trace file and instructions how to analyze it on its standard
CairoLS will print the path to this trace file and instructions on how to analyze it on its standard
error.
In Visual Studio Code you will find this output in the `Output` → `Cairo Language Server` panel.
We're not copying these here because nobody will bother keeping this document in sync.
Expand All @@ -74,7 +74,7 @@ We're not copying these here because nobody will bother keeping this document in

If you find a short reproduction of your problem, we strongly suggest writing an E2E test and
including it in your PR.
Not only this will make your development cycle faster (because checking your changes will be now
Not only will this make your development cycle faster (because checking your changes will be now
automated),
but you will also enable future developers not to fall into the pitfall that caused the bug you
found and debugged 🤓.
Expand Down
3 changes: 1 addition & 2 deletions docs/FEATURE_PARITY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Cairo 0 Features Parity

In this page we track the missing features to reach feature parity with the old compiler version. We divided them by Cairo, Starknet and specific system calls in Starknet OS.
On this page we track the missing features to reach feature parity with the old compiler version. We divided them by Cairo, Starknet and specific system calls in Starknet OS.

If we missed a feature, please let us know.

Expand Down Expand Up @@ -56,5 +56,4 @@
| get_sequencer_address | ✅ |
| get_transaction_info | ✅ |
| send_message_to_l1 | ✅ |
| deploy | ✅ |