feat(blockifier): support Cairo1 local recompilation

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• feat(blockifier): recompile Cairo1 in the CI #197
• chore(blockifier): add is_legacy method #196
• chore(blockifier): add text file with current compiler version for CI use #195
• chore(blockifier): verify local cairo repo state before compiling #194
• feat(blockifier): support Cairo1 local recompilation #184 👈
• chore(blockifier): verify cairo compiler repo (with correct tag) #183
• feat(blockifier): verify cairo-lang version before Cairo0 compilation #182
• chore(blockifier): fetch compiler repo version #181
• chore(blockifier): move contract compilation logic to separate module + contracts.rs #180
• chore(blockifier): refactor feature contract path getters for different paths #179
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.682 ms 35.105 ms 35.602 ms]
change: [+1.3730% +2.5866% +3.9352%] (p = 0.00 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
6 (6.00%) high mild
8 (8.00%) high severe

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Please upload report for BASE (07-29-chore_blockifier_verify_cairo_compiler_repo_with_correct_tag_@b4e9649). Learn more about missing BASE report.

Files	Patch %	Lines
crates/blockifier/src/test_utils/cairo_compile.rs	0.00%	37 Missing ⚠️
crates/blockifier/src/test_utils/contracts.rs	0.00%	10 Missing ⚠️

Additional details and impacted files

@@                                          Coverage Diff                                           @@
##             07-29-chore_blockifier_verify_cairo_compiler_repo_with_correct_tag_     #184   +/-   ##
======================================================================================================
  Coverage                                                                       ?   76.24%           
======================================================================================================
  Files                                                                          ?      330           
  Lines                                                                          ?    35104           
  Branches                                                                       ?    35104           
======================================================================================================
  Hits                                                                           ?    26765           
  Misses                                                                         ?     6045           
  Partials                                                                       ?     2294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.697 ms 65.781 ms 65.874 ms]
change: [-9.6039% -6.0570% -2.8548%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.565 ms 65.645 ms 65.736 ms]
change: [-9.9533% -6.5400% -3.5059%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.924 ms 65.031 ms 65.149 ms]
change: [-10.420% -7.3910% -4.7155%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.746 ms 64.838 ms 64.950 ms]
change: [-7.4846% -4.1411% -1.3395%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.607 ms 64.675 ms 64.757 ms]
change: [-10.881% -7.0324% -3.7081%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe

[TzahiTaub]

Reviewed 5 of 5 files at r9, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @noaov1)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 174 at r9 (raw file):

}

fn verify_cairo1_compiler_deps(git_tag_override: Option<String>) {

verify sounds like a no-side-effect action.

Suggestion:

prepare_cairo1_compiler_deps

---

crates/blockifier/src/test_utils/contracts.rs line 279 at r9 (raw file):

                    Self::LegacyTestContract => (
                        // Legacy contract requires specific compiler tag (which is the point of
                        // the test contract), + to build the compiler an

I don't understand the sentence (== this is why the test contract exists?)

Suggestion:

which is the point of the test contract

---

crates/blockifier/src/test_utils/contracts.rs line 282 at r9 (raw file):

                        // older rust version is required.
                        Some(LEGACY_CONTRACT_COMPILER_TAG.into()),
                        Some(String::from("2023-07-05")),

Why 1 is const and the other isn't?

Code quote:

                        Some(LEGACY_CONTRACT_COMPILER_TAG.into()),
                        Some(String::from("2023-07-05")),

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, @noaov1, and @TzahiTaub)

---

crates/blockifier/src/test_utils/contracts.rs line 279 at r9 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

I don't understand the sentence (== this is why the test contract exists?)

better?

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.773 ms 64.859 ms 64.958 ms]
change: [-9.6684% -6.5893% -3.9304%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

[TzahiTaub]

Reviewed 2 of 2 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1)

---

crates/blockifier/src/test_utils/contracts.rs line 279 at r9 (raw file):

Previously, dorimedini-starkware wrote…

better?

Much

[dorimedini-starkware]

Merge activity

• Aug 11, 11:28 AM EDT: @dorimedini-starkware started a stack merge that includes this pull request via Graphite.
• Aug 11, 12:11 PM EDT: Graphite rebased this pull request as part of a merge.
• Aug 11, 12:23 PM EDT: @dorimedini-starkware merged this pull request with Graphite.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.533 ms 64.595 ms 64.666 ms]
change: [-2.5929% -1.8449% -1.1593%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.474 ms 64.528 ms 64.596 ms]
change: [-8.6383% -5.3171% -2.4405%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severe