feat(blockifier): recompile Cairo1 in the CI

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• feat(blockifier): recompile Cairo1 in the CI #197 👈
• chore(blockifier): add is_legacy method #196
• chore(blockifier): add text file with current compiler version for CI use #195
• chore(blockifier): verify local cairo repo state before compiling #194
• feat(blockifier): support Cairo1 local recompilation #184
• chore(blockifier): verify cairo compiler repo (with correct tag) #183
• feat(blockifier): verify cairo-lang version before Cairo0 compilation #182
• chore(blockifier): fetch compiler repo version #181
• chore(blockifier): move contract compilation logic to separate module + contracts.rs #180
• chore(blockifier): refactor feature contract path getters for different paths #179
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[TzahiTaub]

Reviewed 1 of 2 files at r10, 2 of 2 files at r11, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @aner-starkware, @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @noaov1)

---

.github/workflows/blockifier_compiled_cairo.yml line 14 at r11 (raw file):

      - 'crates/blockifier/feature_contracts/**'
      - 'crates/blockifier/src/test_utils/cairo_compile.rs'
      - 'crates/blockifier/tests/**'

Shouldn't this specify the two files currently in the dir instead? (So future files won't trigger this action)

Code quote:

 'crates/blockifier/tests/**'

---

.github/workflows/blockifier_compiled_cairo.yml line 58 at r11 (raw file):

        with:
          repository: 'starkware-libs/cairo'
          fetch-depth: 0

By the docs

    # Whether to fetch tags, even if fetch-depth > 0.
    # Default: false
    fetch-tags: ''

we only need the tags don't we?

Suggestion:

 fetch-depth: 1

---

crates/blockifier/tests/feature_contracts_compatibility_test.rs line 23 at r11 (raw file):

// Then, run the FIX_COMMAND above.

// To test Cairo1 feature contracts, first clone the Cairo repo and checkout the required tag.

Suggestion:

To fix Cairo1

[dorimedini-starkware]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @aner-starkware, @AvivYossef-starkware, @meship-starkware, @noaov1, and @TzahiTaub)

---

.github/workflows/blockifier_compiled_cairo.yml line 14 at r11 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Shouldn't this specify the two files currently in the dir instead? (So future files won't trigger this action)

Done.

---

.github/workflows/blockifier_compiled_cairo.yml line 58 at r11 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

By the docs

    # Whether to fetch tags, even if fetch-depth > 0.
    # Default: false
    fetch-tags: ''

we only need the tags don't we?

Done. thanks!

---

crates/blockifier/tests/feature_contracts_compatibility_test.rs line 23 at r11 (raw file):

// Then, run the FIX_COMMAND above.

// To test Cairo1 feature contracts, first clone the Cairo repo and checkout the required tag.

Done.

[TzahiTaub]

Reviewed 3 of 3 files at r12, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware, @AvivYossef-starkware, @meship-starkware, and @noaov1)

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware, @AvivYossef-starkware, @meship-starkware, and @noaov1)

---

.github/workflows/blockifier_compiled_cairo.yml line 58 at r11 (raw file):

Previously, dorimedini-starkware wrote…

Done. thanks!

didn't work, reverting

[TzahiTaub]

Reviewed 1 of 1 files at r13.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @aner-starkware, @AvivYossef-starkware, @meship-starkware, and @noaov1)

---

.github/workflows/blockifier_compiled_cairo.yml line 58 at r11 (raw file):

Previously, dorimedini-starkware wrote…

didn't work, reverting

OK, pretty annoying. Do you wanna try something else or give up?
We can try:

- uses: actions/checkout@v4
  with:
    fetch-depth: 0
    filter: object:type=tag

(reached to here from the above link)

[TzahiTaub]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware, @AvivYossef-starkware, @meship-starkware, and @noaov1)

[dorimedini-starkware]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @aner-starkware, @AvivYossef-starkware, @meship-starkware, @noaov1, and @TzahiTaub)

---

.github/workflows/blockifier_compiled_cairo.yml line 58 at r11 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

OK, pretty annoying. Do you wanna try something else or give up?
We can try:

- uses: actions/checkout@v4
  with:
    fetch-depth: 0
    filter: object:type=tag

(reached to here from the above link)

trying now...

[dorimedini-starkware]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @aner-starkware, @AvivYossef-starkware, @meship-starkware, @noaov1, and @TzahiTaub)

---

.github/workflows/blockifier_compiled_cairo.yml line 58 at r11 (raw file):

Previously, dorimedini-starkware wrote…

trying now...

nope

filter 'object:type' not supported

[dorimedini-starkware]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware, @AvivYossef-starkware, @meship-starkware, and @noaov1)

[dorimedini-starkware]

Dismissed @aner-starkware from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware, @AvivYossef-starkware, @meship-starkware, and @noaov1)