Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Bard's "Strike" mark by default #2517

Closed
billmn opened this issue Sep 23, 2020 · 0 comments · Fixed by #2524
Closed

Render Bard's "Strike" mark by default #2517

billmn opened this issue Sep 23, 2020 · 0 comments · Fixed by #2524
Labels

Comments

@billmn
Copy link
Contributor

billmn commented Sep 23, 2020

Bug Description

If you use the "strike" button in a Bard, the tag <s> was not rendered on the template.

HTML source in the Bard:

Schermata 2020-09-23 alle 12 32 13

Template render:

Schermata 2020-09-23 alle 12 33 10

Template code

{{ description }}
    {{ if type == 'text' }}
        <div class="paragraph">{{ text }}</div>
    {{ /if }}
{{ /description }}

To fix this I have added Augmentor::addMark(Strike::class) in the boot method of AppServiceProvider but i think it should be provided as default.

Statamic version: 3.0.12

@robdekort robdekort added the bard label Sep 24, 2020
jasonvarga added a commit that referenced this issue Sep 24, 2020
* Update prosemirror-to-html package. Closes #2517

* Update html-to-prosemirror package

* Replace the now-default image node with our own custom one.

* Tidying, now that the methods are chainable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants