Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bard Dependencies #2524

Merged
merged 4 commits into from
Sep 24, 2020
Merged

Update Bard Dependencies #2524

merged 4 commits into from
Sep 24, 2020

Conversation

jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented Sep 23, 2020 •
edited
Loading

This PR updates the html-to-prosemirror and prosemirror-to-html packages.

  • Scrumpy has been removed from their namespace.
  • Added values() to removeDisabledSets() because it didn't like that the keys were not zero indexed. It would result in nothing being output. I think it's this change.
  • Closes Render Bard's "Strike" mark by default #2517 because the updated version of prosemirror-to-html includes the strike mark by default.
  • Replace the now-default image node with our own custom one which has the asset url support.

@jasonvarga jasonvarga marked this pull request as ready for review September 24, 2020 15:28
@jasonvarga jasonvarga merged commit 07e3558 into master Sep 24, 2020
@jasonvarga jasonvarga deleted the feature/bard-deps branch September 24, 2020 17:15
@duncanmcclean duncanmcclean mentioned this pull request Sep 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Render Bard's "Strike" mark by default
1 participant
@jasonvarga