Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Cache external url/uri results #9646

Merged
merged 5 commits into from
Mar 13, 2024
Merged

[5.x] Cache external url/uri results #9646

merged 5 commits into from
Mar 13, 2024

Conversation

JohnathonKoster
Copy link
Contributor

This PR adds a simple cache to remember the results of calling isExternal on URLs. This cache is flushed once the response is sent since it relies on the current Site, which may change in SSG-like environments.

@JohnathonKoster JohnathonKoster mentioned this pull request Mar 3, 2024
37 tasks
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target master and adjust the PR title to show [5.x].

@JohnathonKoster JohnathonKoster changed the base branch from 4.x to master March 8, 2024 01:05
@JohnathonKoster JohnathonKoster changed the title [4.x] Cache external url/uri results [5.x] Cache external url/uri results Mar 8, 2024
@jasonvarga jasonvarga dismissed their stale review March 11, 2024 16:59

Requested changes were made.

src/View/State/ClearState.php Outdated Show resolved Hide resolved
@jasonvarga jasonvarga merged commit cb7eaaa into statamic:master Mar 13, 2024
16 checks passed
@jasonvarga jasonvarga deleted the cache-external-url-results branch March 13, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants