-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: channels encryption backend #11657
Conversation
this brings channels encryption
Jenkins Builds
|
Hi @osmaczko , I'll be afk for a while so won't be able to pick this up, sorry. @anastasiyaig or @lukaszso may be able to help though. |
@glitchminer thanks for info! @anastasiyaig could you please take over? |
@osmaczko I've checked both scenarios and here are the results: Community-level encryption:
For channel-level encryption it seems to be working as described, i think it's because while they are on the user is still a part of the community so all the messages are still fetched but not visible maybe? |
Hi @lukaszso, thanks for testing 🙏
Right, that's my mistake. This is expected behavior, user has to manually re-join.
That's an issue. I double-checked and this can be reproduced on master without my changes, so it is not a regression from this PR. I created a separate issue for that: #11686 @lukaszso could you please add these scenarios to TestRail? |
Closing, channels re-keying works fine. I'll bump status-go with another PR. |
What does the PR do
This brings channels encryption backend. Now every token-gated channel should be encrypted behind the scenes. It also includes improved community rekeying.
Affected areas
Test scenarios
Test community-level encryption
Test channel-level encryption
@glitchminer please consider adding above scenarios to regressions tests