feat: introduce CommunitiesKeyDistributor #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osmaczko
requested review from
0x-r4bbit,
cammellos,
Samyoul,
jrainville and
mprakhov
Jenkins BuildsClick to see older builds (70)
|
0x-r4bbit
approved these changes
Jul 19, 2023
| pushNotificationClient: pushNotificationClient, | ||
| pushNotificationServer: pushNotificationServer, | ||
| communitiesManager: communitiesManager, | ||
| communitiesKeyDistributor: &CommunitiesKeyDistributorImpl{ |
There was a problem hiding this comment.
Just cosmetics, but we could have a NewKeyDistributor() factory fn for this
There was a problem hiding this comment.
Was thinking about factory as well, but since this struct doesn't need any special initialization, I left it as is.
| } | ||
|
|
||
| return result | ||
| }() |
There was a problem hiding this comment.
Any reason this is wrapped in an IIFE? Nothing that needs change, just curious
There was a problem hiding this comment.
It represents the intention a bit better, you can read straight away "this piece of code is responsible for obtaining recentlyPublishedOrgs". Also, this way I don't pollute the scope with unneeded ownedOrgs variable.
mprakhov
reviewed
Jul 19, 2023
jrainville
approved these changes
Jul 19, 2023
osmaczko
force-pushed
the
feat/communities-key-distributor
branch
from
cb62bd0 to
a432328
Compare
osmaczko
force-pushed
the
feat/encryption-action
branch
from
af9eecd to
9de6436
Compare
osmaczko
force-pushed
the
feat/communities-key-distributor
branch
from
a432328 to
47c9869
Compare
osmaczko
force-pushed
the
feat/encryption-action
branch
3 times, most recently
from
7a45373 to
2416ffa
Compare
osmaczko
force-pushed
the
feat/communities-key-distributor
branch
7 times, most recently
from
22b6bb1 to
6a39b6d
Compare
|
Waits for QA: status-im/status-desktop#11657 |
Samyoul
approved these changes
Jul 25, 2023
| @@ -35,4 +35,5 @@ type RawMessage struct { | |||
| CommunityKeyExMsgType CommKeyExMsgType | |||
| Ephemeral bool | |||
| BeforeDispatch func(*RawMessage) error | |||
| HashRatchetGroupID []byte | |||
| @@ -3447,47 +3447,49 @@ func (s *MessengerCommunitiesSuite) TestStartCommunityRekeyLoop() { | |||
| s.Require().False(c.Encrypted()) | |||
| // TODO some check that there are no keys for the community. Alt for s.Require().Zero(c.RekeyedAt().Unix()) | |||
|
|
|||
| // Update the community to use encryption and check the values | |||
There was a problem hiding this comment.
were your new changes causing this test to fail?
There was a problem hiding this comment.
It didn't compile because I removed UpdateCommunityEncryption. I will address that in follow-up.
osmaczko
force-pushed
the
feat/communities-key-distributor
branch
4 times, most recently
from
0570a79 to
85c3705
Compare
This component decouples key distribution from the Messenger, enhancing code maintainability, extensibility and testability. It also alleviates the need to impact all methods potentially affecting encryption keys. Moreover, it allows key distribution inspection for integration tests. part of: status-im/status-desktop#10998
- distribute ratchet keys at both community and channel levels - use explicit `HashRatchetGroupID` in ecryption layer, instead of inheriting `groupID` from `CommunityID` - populate `HashRatchetGroupID` with `CommunityID+ChannelID` for channels, and `CommunityID` for whole community - hydrate channels with members; channel members are now subset of community members - include channel permissions in periodic permissions check closes: status-im/status-desktop#10998
osmaczko
force-pushed
the
feat/communities-key-distributor
branch
from
85c3705 to
5d901bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
CommunitiesKeyDistributorThis component decouples key distribution from the Messenger, enhancing code maintainability, extensibility and testability. It also alleviates the need to impact all methods potentially affecting encryption keys.
Moreover, it allows key distribution inspection for integration tests.
part of: status-im/status-desktop#10998