New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement encryption for channel permissions #10998

Closed

Tracked by

jrainville opened this issue Jun 8, 2023 · 0 comments

Closed

Tracked by

Implement encryption for channel permissions #10998

jrainville opened this issue Jun 8, 2023 · 0 comments

Assignees

Labels

feature

Milestone

Member

jrainville commented Jun 8, 2023 •

edited

Loading

Description

Part of Epic #10598

This is a status-go issue, but it's simpler for us to track if it's here.

With this task, we need to add encryption for each channel token permission.

The only exception is the "everyone is able to read permission", aka "read-only" channels, because there is no token attached. What that means if if the switch on "who holds" is turned off, then the permission applies to everyone. Then a "View only" permission on a channel means that everyone has a right to read it, but not write, except admins and owners. Then it that particular case, it would not be encrypted, because everyone can still read (it might still be encrypted because of community encryption)

Acceptance Criteria

When a token permission is added to a channel, then that channel becomes independently encrypted. Only people that fulfill that permission will have access to the key to un-encrypt the channel.

jrainville added Communities feature labels

jrainville added this to the 0.14 milestone

jrainville added this to Status Desktop/Mobile Board

jrainville mentioned this issue

[EPIC] [Community Permission] Channel based permissions #10598

Closed

6 tasks

iurimatias modified the milestones: 0.14, 0.15

iurimatias added the C1 label

jrainville assigned osmaczko

jrainville moved this to Next Iteration in Status Desktop/Mobile Board

osmaczko moved this from Next Iteration to Iteration Backlog in Status Desktop/Mobile Board

osmaczko moved this from Iteration Backlog to In Progress in Status Desktop/Mobile Board

jrainville added E:DChannelBasedPermissionsImplementation and removed E:Communities labels

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: add CommunityEncryptionKeyActions and its evaluation logic

ff14b3f

Added utility that evaluates necessary encryption key actions based on
community changes.

part of: status-im/status-desktop#10998

osmaczko mentioned this issue

feat: add CommunityEncryptionKeyActions and its evaluation logic status-im/status-go#3765

Merged

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: add CommunityEncryptionKeyActions and its evaluation logic

97b3568

Added utility that evaluates necessary encryption key actions based on
community changes.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: add CommunityEncryptionKeyActions and its evaluation logic

f8f7989

Added utility that evaluates necessary encryption key actions based on
community changes.

part of: status-im/status-desktop#10998

jrainville removed the Communities label

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: add CommunityEncryptionKeyActions and its evaluation logic

af9eecd

Added utility that evaluates necessary encryption key actions based on
community changes.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce CommunitiesKeyDistributor

cb62bd0

This component decouples key distribution from the Messenger, enhancing
code maintainability, extensibility and testability.
It also alleviates the need to impact all methods potentially affecting
encryption keys.
Moreover, it allows key distribution inspection for integration tests.

part of: status-im/status-desktop#10998

osmaczko mentioned this issue

feat: introduce CommunitiesKeyDistributor status-im/status-go#3774

Merged

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce CommunitiesKeyDistributor

a432328

This component decouples key distribution from the Messenger, enhancing
code maintainability, extensibility and testability.
It also alleviates the need to impact all methods potentially affecting
encryption keys.
Moreover, it allows key distribution inspection for integration tests.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: add CommunityEncryptionKeyActions and its evaluation logic

9de6436

Added utility that evaluates necessary encryption key actions based on
community changes.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: add CommunityEncryptionKeyActions and its evaluation logic

dc3ae77

Added utility that evaluates necessary encryption key actions based on
community changes.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce CommunitiesKeyDistributor

47c9869

This component decouples key distribution from the Messenger, enhancing
code maintainability, extensibility and testability.
It also alleviates the need to impact all methods potentially affecting
encryption keys.
Moreover, it allows key distribution inspection for integration tests.

part of: status-im/status-desktop#10998

jrainville added C2 and removed C1 labels

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce CommunitiesKeyDistributor

0cd5c2d

This component decouples key distribution from the Messenger, enhancing
code maintainability, extensibility and testability.
It also alleviates the need to impact all methods potentially affecting
encryption keys.
Moreover, it allows key distribution inspection for integration tests.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

a9e29db

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce CommunitiesKeyDistributor

9a889cc

This component decouples key distribution from the Messenger, enhancing
code maintainability, extensibility and testability.
It also alleviates the need to impact all methods potentially affecting
encryption keys.
Moreover, it allows key distribution inspection for integration tests.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

3faee08

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

82166bd

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

ebdbf7b

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko mentioned this issue

Feat/channels encryption status-im/status-go#3789

Merged

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

8df128f

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

7afa312

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

8e86295

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko moved this from In Progress to Code review in Status Desktop/Mobile Board

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

ed8dc60

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

5bc5dae

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce CommunitiesKeyDistributor

d5b62ec

This component decouples key distribution from the Messenger, enhancing
code maintainability, extensibility and testability.
It also alleviates the need to impact all methods potentially affecting
encryption keys.
Moreover, it allows key distribution inspection for integration tests.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

22b6bb1

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce CommunitiesKeyDistributor

e20eb6b

This component decouples key distribution from the Messenger, enhancing
code maintainability, extensibility and testability.
It also alleviates the need to impact all methods potentially affecting
encryption keys.
Moreover, it allows key distribution inspection for integration tests.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

6a39b6d

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

7ab934f

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce CommunitiesKeyDistributor

527e51c

This component decouples key distribution from the Messenger, enhancing
code maintainability, extensibility and testability.
It also alleviates the need to impact all methods potentially affecting
encryption keys.
Moreover, it allows key distribution inspection for integration tests.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

b25c1d4

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce CommunitiesKeyDistributor

cf0b09b

This component decouples key distribution from the Messenger, enhancing
code maintainability, extensibility and testability.
It also alleviates the need to impact all methods potentially affecting
encryption keys.
Moreover, it allows key distribution inspection for integration tests.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

b1cb282

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce CommunitiesKeyDistributor

3f6963d

This component decouples key distribution from the Messenger, enhancing
code maintainability, extensibility and testability.
It also alleviates the need to impact all methods potentially affecting
encryption keys.
Moreover, it allows key distribution inspection for integration tests.

part of: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce channel-level encryption

65bc869

- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

osmaczko added a commit to status-im/status-go that referenced this issue


          feat: introduce CommunitiesKeyDistributor

30da839

This component decouples key distribution from the Messenger, enhancing
code maintainability, extensibility and testability.
It also alleviates the need to impact all methods potentially affecting
encryption keys.
Moreover, it allows key distribution inspection for integration tests.

part of: status-im/status-desktop#10998

osmaczko closed this as completed in


      status-im/status-go@367b772

github-project-automation bot moved this from Code review to Done in Status Desktop/Mobile Board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment